App: [HOLD for payment 2023-10-27] [$250] Migrate index.js to function component
Class Component Migration
Filenames
Task
- We currently have some class components in our codebase that we would like to refactor to a function component.
- Here’s a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
- If you need additional guidance, please ask in #expensify-open-source
- Test for any regressions and verify that there are no breaking changes
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01eb40815378adee79
- Upwork Job ID: 1710087370262638592
- Last Price Increase: 2023-10-06
Issue Owner
Current Issue Owner: @johncschusterAbout this issue
- Original URL
- State: closed
- Created a year ago
- Comments: 41 (16 by maintainers)
@ashuvssut I like your proposal, but it’s doing too much.
❌ Refactoring into separate components
No need to do this. We are just focused on the conversion to a function component
❌ Refactoring into Custom Hooks
Sounds like a premature optimization.
❌ Use TypeScript for props types and function parameter type(Also this renames file extension:-*.js into *.tsx)
We have a separate migration happening related to TS so this is more than we are asking for. Do not do it.
The rest sounds ok!
@ashuvssut can you please comment on the issue above so I can assign it to you? That should create the Upwork job.
@johncschuster Bump for the above, also please leave a payment summary message!
@johncschuster @marcaaron any update on the payment issue?