App: [HOLD for payment 2023-10-24] [$1000] Chat - Edit code block inside strike-through moves edited label down

Regression Test Proposal

1. Open any report
2. Paste ~```Code```~ into the composer and send the message
3. Verify that the code block text doesn’t get strike-through line
4. Verify that there’s a ~ symbol above and below the code block

Do we agree 👍 or 👎

@trjExpensify I have received offer of 50 instead of 250. Please check and update.

@mallenexpensify will likely take care of it when we’re ready for payments.

@Krishna2323 do not needlessly bump/@mention Expensifiers please

d’oh, sorry about that @DinalJivani , I was following the auto-amount and should have checked the date the bug was reported. I bonused you $200 and updated the comment above so that it’s correct.

Just noting that the PR in expensify-common repo was merged within 2 days and PR in this repo was approved and reviewed by @eVoloshchak within 3 working days of assignment.

@eVoloshchak, PR for hash update, pls review, IOS native and Android Native demo will be updated in few minutes.

Yeah, Alex and I were talking about that in the other issue and I agree. He’s going to dismantle that tracker, so feel free to move forward here.

whenever code blocks are used with three ticks the codeblock markdown should take precedence over other markdown since it’s intended purpose is to be a block of characters in it’s own line. If we agree on that, then the bug would be that having the ~ before the codeblock should show the same way at the bold and the italic options above do.

Agree with this, it should be consistent with how bold and italic are handled

@Krishna2323’s proposal looks good to me There is an inconsistency with how markdown is shown when editing a message But the same happens for bold and italic, so it’s unrelated to @Krishna2323’s changes (and is intentional according to this comment)

🎀👀🎀 C+ reviewed!

I did some more testing on desktop and here’s how bold and italic show

Which makes me think that, whenever code blocks are used with three ticks the codeblock markdown should take precedence over other markdown since it’s intended purpose is to be a block of characters in it’s own line. If we agree on that, then the bug would be that having the ~ before the codeblock should show the same way at the bold and the italic options above do… right? (sorry if this was discussed before, at some point I was thinking single tick for markdown and not three ticks

@Krishna2323 This was discussed in Slack thread.

And this issue was reported later than current issue. Not sure what will be next Step 😅 Let’s wait for team to review

I agree with @yh-0218’s assessment of the root cause, this is indeed caused by a <del> tag, however

• I’m not sure if applyStrikethrough is the right place to apply the fix, could we do that in htmlToMarkdownRules?
• Most importantly, why does it work incorrectly only on native platforms? (verified Android also has this problem). Is this an issue with react-native-render-html itself? If so, I think it’s best we fix it in their repo

Can we get a new CME here @Expensify/bug-zero as @mallenexpensify is OOO?

Also, I’m unassigning myself to due low bandwidth, Please assign a new C+ plus here, thanks!

cc: @anmurali