App: [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [$500] Dev: Distance - Infinite loop running set camera after select waypoint.
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Run the app locally on native Android/iOS.
- Go to file
src/components/MapView/MapView.tsxand add console.log inside useFocusEffect > useCallback. - Go to the app, and click fab icon > request money > distance.
- Add waypoint and notice the console.log inside useFocusEffect > useCallback is logged infinity.
Expected Result:
The useFocusEffect > useCallback should run once.
Actual Result:
The useFocusEffect > useCallback run Infinite.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: Dev 1.3.74-2 Reproducible in staging?: n/a Reproducible in production?: n/a If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/07b7d75c-4e53-4e8c-bfd4-f687155f7edc
https://github.com/Expensify/App/assets/93399543/93a68bad-d7cf-428d-827c-dfccada63ef1
Expensify/Expensify Issue URL: Issue reported by: @ahmedGaber93 Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695754900325509
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01f3599c42c6c62223
- Upwork Job ID: 1707091998614892544
- Last Price Increase: 2023-10-04
- Automatic offers:
- jjcoffee | Reviewer | 27123589
- ahmedGaber93 | Contributor | 27123590
- ahmedGaber93 | Reporter | 27123592
Issue Owner
Current Issue Owner: @anmuraliAbout this issue
- Original URL
- State: closed
- Created 9 months ago
- Comments: 36 (18 by maintainers)
@neil-marcellini Ah apologies, I misinterpreted your comment - I thought you wanted to take over the proposal review 😅
FWIW agree that the proposal looks good - the RCA is correct and the solution is neat 'n tidy!
@ahmedGaber93’s proposal looks great. Awesome root cause explanation. Hired!