App: [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [$250] Migrate RequestorOnfidoStep.js to function component
Class Component Migration
Filenames
Task
- We currently have some class components in our codebase that we would like to refactor to a function component.
- Here’s a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
- If you need additional guidance, please ask in #expensify-open-source
- Test for any regressions and verify that there are no breaking changes
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~0108c7eff871f84756
- Upwork Job ID: 1702336246230073344
- Last Price Increase: 2023-09-14
About this issue
- Original URL
- State: closed
- Created a year ago
- Comments: 31 (20 by maintainers)
@jliexpensify I wasn’t assigned to the PR, and I didn’t review it. Therefore, no payment is due to me.
@barttom As it is still in the regression period, I found a console warning and reported here, https://github.com/Expensify/App/issues/29868.
Reason: We switched to
useLocalizeand removedwithLocalizebutStepPropTypesexpects a propwithLocalizePropTypeswhich is now missing.@jliexpensify It has been merged
@jliexpensify I’m a part of callstack team, so I afaik they are care of invoices 😉
Hey @jliexpensify! This issue is on me, I just need to merge main branch into mine fetuje branch, but I’m on OOO until end of this week
Proposal
Issue
Migration from RequestorOnfidoStep.js class to function
Solution
Create a function corresponding the class and migrate the functionalities to it in addition to updating the references to the class for instance if there is some import in a component like below
import {RequestorOnfidoStep}then it should becomeimport RequestorOnfidoStepUpwork Profile: https://www.upwork.com/freelancers/rosemiller Expensify Email: thisisrosemiller@gmail.com
@neonbhai don’t spam proposal on hold Gh try to find migration on unhold issues