App: [HOLD for payment 2023-10-16] [$500] Approved requests shouldn't have a `delete` option
While we’ve already implemented logic preventing paid requests from being deleted, the same isn’t true for approved requests, which we’ve just added. Accordingly, let’s remove the Delete request option from the three dot overflow menu anytime a request has been approved.
Here’s mock for clarity. Notice how I’ve removed the Delete request option.
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01bd5a594a7f989566
- Upwork Job ID: 1697326804261687296
- Last Price Increase: 2023-08-31
- Automatic offers:
- cubuspl42 | Reviewer | 26523887
- Pujan92 | Contributor | 26523889
About this issue
- Original URL
- State: closed
- Created 10 months ago
- Comments: 58 (34 by maintainers)
I don’t think this is specific to the TU policy, but instead to all approved requests. That said, I can make those tweaks in the regression test. Now that @Pujan92 has been paid out, I’m going to close this issue.
One of the reasons it took so long is that the issue was related to Teachers Unite / corporate policies, which require extra setup to test.
Sorry for the delay, don’t hesitate to reach out via DM on NewDot if you don’t get a fast response. I can go in and approve your request now.
https://expensify.slack.com/archives/C049HHMV9SM/p1693912029208039
Applause is unable to reproduce, can anyone spot the missing step that they might need to configure the correct env? They should be included in all betas already 😕
Created, https://expensify.slack.com/archives/C049HHMV9SM/p1693912029208039
Both proposals, in their final form, looked similar and contained convincing root cause analysis and solution plan. Honoring the suggestion by @jeet-dhandha, I say we go with @Pujan92 proposal.
At the implementation phase, we’ll need to ensure that we have appropriate permissions and capabilities to test the solution thoroughly.
C+ reviewed 🎀 👀 🎀
@cubuspl42 Let @Pujan92 have this one 👍 .