App: [HOLD for payment 2023-10-12] [$500] HIGH: Add ability to `request money` from within `IOU` and `expense reports

At the moment we allow the ability to request money via the big green plus button, aka “Global Create”. We also allow you to create requests via a policyExpenseChat and even DM. Curiously, we don’t allow you to request money via either an IOU or expense report, and we should, especially given that you can create a task in any report. Here’s an example of the issue at hand. Notice there is no request money option.

Screenshot 2023-09-04 at 11 22 09

Accordingly, let’s add request money to IOU and expense reports as well, just like the policyExpenseChat.

Note: One special consideration is that we shouldn’t show the Request money button when a report reaches the approved or reimbursed state, as at that point reports become “locked” and no new requests can be added to them.

cc @mountiny You might decide to take this one, so I’m keeping it internal until you decide one way or another.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0166385e94742cacb0
  • Upwork Job ID: 1700387490099986432
  • Last Price Increase: 2023-09-09

About this issue

  • Original URL
  • State: closed
  • Created 10 months ago
  • Comments: 31 (18 by maintainers)

Most upvoted comments

@dukenv0307 I am not sure if we havent missed the case of the payer though which would be a regression. With your PR, I dont think the payer would be able to request money at the IOU report. I did not see it tested in the PR.

Will expense report and iou report be displayed as an option when we choose participants in participant page?

Haha, great thinking! cc @JmillsExpensify

No not in this PR, its out of scope, we will handle it elsewhere

the request will be added to the report preview of the chat report or it will be a new request?

There will be a new request/ transaction on the IOU/expense report and then we need to update the report preview (which at this point should always exist). This will be the number of the requests also meaking sure the correct number of receipts/ images shows there