App: [HOLD for payment 2023-09-27] [$500] `webpack-dev-server` warnings show in JS console

cc @cead22

Letโ€™s fix these.

index.js:556 [webpack-dev-server] Warnings while compiling.
logger @ index.js:556
eval @ index.js:730
warn @ index.js:189
warnings @ index.js:234
eval @ socket.js:60
client.onmessage @ WebSocketClient.js:50
index.js:556 [webpack-dev-server] WARNING in ./node_modules/react-native-performance/lib/module/NativeRNPerformanceManager.js 2:15-38
export 'TurboModuleRegistry' (imported as 'TurboModuleRegistry') was not found in 'react-native' (possible exports: AccessibilityInfo, ActivityIndicator, Alert, Animated, AppRegistry, AppState, Appearance, BackHandler, Button, CheckBox, Clipboard, DeviceEventEmitter, DeviceInfo, Dimensions, DrawerLayoutAndroid, Easing, FlatList, I18nManager, Image, ImageBackground, InputAccessoryView, InteractionManager, Keyboard, KeyboardAvoidingView, LayoutAnimation, Linking, LogBox, Modal, NativeEventEmitter, NativeModules, PanResponder, PermissionsAndroid, Picker, PixelRatio, Platform, Pressable, ProgressBar, RefreshControl, SafeAreaView, ScrollView, SectionList, Settings, Share, StatusBar, StyleSheet, Switch, Systrace, TVEventHandler, Text, TextInput, ToastAndroid, Touchable, TouchableHighlight, TouchableNativeFeedback, TouchableOpacity, TouchableWithoutFeedback, UIManager, Vibration, View, VirtualizedList, YellowBox, findNodeHandle, processColor, render, unmountComponentAtNode, unstable_createElement, useColorScheme, useLocaleContext, useWindowDimensions)
logger @ index.js:556
eval @ index.js:730
warn @ index.js:189
warnings @ index.js:247
eval @ socket.js:60
client.onmessage @ WebSocketClient.js:50
index.js:556 [webpack-dev-server] WARNING in ./node_modules/react-native-svg/lib/module/ReactNativeSVG.web.js 8:22-24
export 'createElement' (imported as 'cE') was not found in 'react-native' (possible exports: AccessibilityInfo, ActivityIndicator, Alert, Animated, AppRegistry, AppState, Appearance, BackHandler, Button, CheckBox, Clipboard, DeviceEventEmitter, DeviceInfo, Dimensions, DrawerLayoutAndroid, Easing, FlatList, I18nManager, Image, ImageBackground, InputAccessoryView, InteractionManager, Keyboard, KeyboardAvoidingView, LayoutAnimation, Linking, LogBox, Modal, NativeEventEmitter, NativeModules, PanResponder, PermissionsAndroid, Picker, PixelRatio, Platform, Pressable, ProgressBar, RefreshControl, SafeAreaView, ScrollView, SectionList, Settings, Share, StatusBar, StyleSheet, Switch, Systrace, TVEventHandler, Text, TextInput, ToastAndroid, Touchable, TouchableHighlight, TouchableNativeFeedback, TouchableOpacity, TouchableWithoutFeedback, UIManager, Vibration, View, VirtualizedList, YellowBox, findNodeHandle, processColor, render, unmountComponentAtNode, unstable_createElement, useColorScheme, useLocaleContext, useWindowDimensions)
logger @ index.js:556
eval @ index.js:730
warn @ index.js:189
warnings @ index.js:247
eval @ socket.js:60
client.onmessage @ WebSocketClient.js:50
index.js:556 [webpack-dev-server] WARNING in ./src/libs/actions/Device/getDeviceInfo/getBaseInfo.js 4:17-24
Should not import the named export 'version' (imported as 'version') from default-exporting module (only default export is available soon)

2023-09-07_09-53-31

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0188c71c3d9384236e
  • Upwork Job ID: 1700244683779788800
  • Last Price Increase: 2023-09-08

About this issue

  • Original URL
  • State: closed
  • Created 10 months ago
  • Comments: 27 (14 by maintainers)

Most upvoted comments

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: N/A
  • [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
  • [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
  • [@parasharrajat] Determine if we should create a regression test for this bug. N/A
  • [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Ok. Thanks. I donโ€™t expect anyone to lay down all the required changes. Testing is sufficient which signifies that you made sure that the app is working after these changes. If something unexpected is found on PR, then it will have to be handled as part of this issue.

On this note, I am fine with @allroundexpertsโ€™s proposal.

There is a Performance.js lib which will also need to be migrated and tested against the new version.

๐ŸŽ€ ๐Ÿ‘€ ๐ŸŽ€ C+ reviewed

yep I think we are just treating it as a โ€œbugโ€.