App: [HOLD for payment 2023-09-18] [$500] Dev: console error if we open RHN page directly

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Try to open direct link of RHN(for eg, http://localhost:8082/settings)
Observe the console error

Expected Result:

Should not occur console error Actual Result: Error Failed prop type: The prop isBlockedFromConciergeis marked as required inAttachmentPickerWithMenuItems, but its value is undefined. occurs

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop

Version Number: DEV Reproducible in staging?: dev Reproducible in production?: dev If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/43996225/9ff55e9e-0e2f-4662-a396-a6e5487bf0b2

Expensify/Expensify Issue URL: Issue reported by: @Pujan92 Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692985306887049

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~013c4503a94278a1ad
Upwork Job ID: 1699435322866675712
Last Price Increase: 2023-09-06
Automatic offers:

situchan | Reviewer | 26527992
Pujan92 | Contributor | 26527994
Pujan92 | Reporter | 26527998

About this issue

Original URL
State: closed
Created 10 months ago
Comments: 39 (23 by maintainers)

Most upvoted comments

Oh, ok @sonialiap. I thought all payments needs to be with old price. Thanks for clearing.

Pujan92 on Sep 26, 2023

This doesn’t require BZ checklist. Console error check is already in PR checklist and it’s just dev error, not affecting production app.

situchan on Sep 19, 2023

Just doing an expedited review as this is annoying. When refresh app every time, hard to see other console errors caused by test branch as this one shows always.

@Pujan92’s proposal looks good - !_.isEmpty(report.participantAccountIDs)

@sonialiap as this is dev-only issue, I am going to pull up engineer directly - 🎀 👀 🎀 C+ reviewed

situchan on Sep 6, 2023