App: [HOLD for payment 2023-07-26] [$1000] Attachments not shown for sender, stuck at 'Uploading attachment...'
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Open any chat (group or 1:1)
- Add an image attachment
Uploading attachment...should show temporarily
Expected Result:
- After upload, other users should see the attachment
- After upload, the uploader should image attachment should show
Actual Result:
- After upload, other users can see the attachment ✅
- After upload, the uploader cannot see the image attachment (‘Uploading attachment…’ is still shown) ❌
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- [?] iOS / native
- [?] iOS / Safari
- [?] MacOS / Chrome / Safari
- [?] MacOS / Desktop
Version Number: 1.3.39-5 and 1.3.38-7
Reproducible in staging?: Yes
Reproducible in production?: Yes
Issue reported by: Me
Slack conversation: N/A
Uploader (jules) sees:
Other user sees:
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~019a63d2e48d9abd42
- Upwork Job ID: 1679142267668922368
- Last Price Increase: 2023-07-12
About this issue
- Original URL
- State: closed
- Created a year ago
- Comments: 25 (13 by maintainers)
FFS. Not again. Going back to Conor as he was the original assignee
Proposal
Please re-state the problem that we are trying to solve in this issue.
Attachments not shown for sender, stuck at ‘Uploading attachment…’
What is the root cause of that problem?
Seems we are passing wrong value(undefined) here for
prevVisibleMessageTextLocalize.translateLocalin the latest PR which seems breaking the flow for attachment. https://github.com/Expensify/App/blob/29ae9421d61c5a05e12408c258f64d4b65c3c2c4/src/libs/actions/Report.js#L248-L250 https://github.com/Expensify/App/commit/1a7bbcf0251a76c234b326b1fee2936e02d99d3e#diff-8afe5b71ee0436c21364148c86dadd640f2bff3e3d916addbb1f1f6f7e5b6a43R248-R250What changes do you think we should make in order to solve the problem?
We need to correct the value we are passing. cc: @roryabraham
prevVisibleMessageText = Localize.translateLocal(lastVisibleMessage.lastMessageTranslationKey);The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/22724
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/22724#discussion_r1262931017
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not required because it’s a typo-ish.
Determine if we should create a regression test for this bug. No
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again - N.A.
Ok, it’s two days past payday, sorry! Here’s what I’m going to do:
Hey @conorpendergrast - @gadhiyamanan reported a similar issue (https://github.com/Expensify/App/issues/22762) 6-7 hours before this GH issue was created, and the PR here ended up fixing the issue he reported. I think that we should pay @gadhiyamanan the reporting bonus since he reportedthe issue first. Could you please send him an offer on this job for $250?
My mistake, good find @Pujan92
📣 @rushatgabhane We’re missing your Upwork ID to automatically send you an offer for the Reviewer role. Once you apply to the Upwork job, your Upwork ID will be stored and you will be automatically hired for future jobs!