App: [HOLD for payment 2023-07-24] [$1000] Unable to Upload PDF & JPEG files that contains a space in the file title

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to any chat
  2. click plus button on the composer and upload a Password Protected PDF attachment with a space in the title (example below)
  3. Observe the error, then dismiss the error
  4. now attach a regular PDF that has a space in the title (example below)
  5. Observe the error, then dismiss the error
  6. now attach a PNG file that has a space in the title
  7. Observe the error again

Expected Result:

able to upload file attachments that contain a space in the file name

Actual Result:

Unexpected error while posting the comment.

“Unexpected error while posting the comment, please try again later. Invalid file attachment”

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.37-2 Reproducible in staging?: y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/43996225/2078320f-e372-4894-bfa8-53420e987f1a

https://github.com/Expensify/App/assets/43996225/444b206e-b9c8-4a5d-8539-2af3c9855ea1

https://github.com/Expensify/App/assets/16232057/7cfb740b-f444-4038-9f63-427e06ff0b74

DATTARAM_SAWANT_AADHAR_CARD 1_.pdf

Example With Space.pdf

Expensify/Expensify Issue URL: Issue reported by: @daveSeife Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688495589932239

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01dc241c0a0b2ba919
  • Upwork Job ID: 1676993011268341760
  • Last Price Increase: 2023-07-06

About this issue

  • Original URL
  • State: closed
  • Created a year ago
  • Comments: 43 (22 by maintainers)

Most upvoted comments

Bump on the checklist, @fedirjh!

In the meantime, confirming these are the payments due to send the offers:

  • No #urgency bonus to consider due to the regression.
  • $500 to @alitoshmatov for the fix, reduced by 50% because of the regression.
  • $500 to @fedirjh for C+, reduced by 50% because of the regression.
  • $250 to @daveSeife for the bug report

Me neither on staging mac chrome:

image

Let’s take this to the thread, I’ve noticed a couple of things from the video:

  1. It’s windows not mac
  2. the preview of the PDF is different than the one supplied

I don’t think this is a deploy blocker.