App: [HOLD for payment 2023-07-14] [$250] Migrate SignInPage.js to function component

Class Component Migration

Filenames

  • src/pages/signin/SignInPage.js
    • type: React.Component
    • has state values: false
    • has refs: false
    • has context: false
    • lifecycle methods: componentDidMount

Task

  • We currently have some class components in our codebase that we would like to refactor to a function component.
  • Here’s a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
  • If you need additional guidance, please ask in #expensify-open-source
  • Test for any regressions and verify that there are no breaking changes
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0184fa212744ee42dc
  • Upwork Job ID: 1668429651374313472
  • Last Price Increase: 2023-06-13

About this issue

  • Original URL
  • State: closed
  • Created a year ago
  • Comments: 29 (19 by maintainers)

Most upvoted comments

Initial PR was reverted and new PR merged yesterday.

+1
sobitneupane on Jul 4, 2023

@Christinadobrzyn The PR for this issue was reverted.

+1
sobitneupane on Jun 16, 2023

Ok, hey @kevinksullivan! The only payment due here is $250 to @sobitneupane 1 week after https://github.com/Expensify/App/pull/19498 hits production.

+1
roryabraham on Jun 13, 2023
Read more comments on GitHub
← App: [HOLD for payment 2023-07-14] [$250] Migrate NewChatPage.js to function component
App: [HOLD for payment 2023-07-14] [$250] Migrate WorkspaceNewRoomPage.js to function component →