App: [HOLD for payment 2023-07-05] [$1000] Web - Chat - Mention list doesn't display when enter special key: '_-+=|\;`~ before:

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to any chat
  2. Enter special key and @he (ex: _@he or `@he or ~@he)

Expected Result:

The mention suggestion display

Actual Result:

The mention suggestion doesn’t display

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.24.4

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screenshot 2023-05-31 at 17 31 14 (1)

Expensify/Expensify Issue URL:

Issue reported by: @dukenv0307

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685529049518369

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~018585a2ed09409031
  • Upwork Job ID: 1666822250965151744
  • Last Price Increase: 2023-06-22

About this issue

  • Original URL
  • State: closed
  • Created a year ago
  • Comments: 43 (28 by maintainers)

Most upvoted comments

@PauloGasparSv So will we add/accept these characters \ ’ ; `

Yes to: \ ; ` No to: '

So the list of accepted should be the following IMO: , / \ ? " { } [ ] ( ) & ^ % $ # < > ! * = ` ;

And let’s not add these characters there were discussed here at some point: _ + - @ ~ | '

@PauloGasparSv @abdulrahuman5196 You can see the current behavior on Slack and on Expensify for more information

I just checked on Slack if we enter some special key before @ or : and check whether the suggestion is displayed or not This is the result

Header Slack Expensify
_ yes no
- yes no
+ yes (if after is 😃 and no (if after is @) no
= no no
| no no
\ no no
; no no
` no no
~ no no
@ no no

BZ checklist

The PR that introduced the bug has been identified. Link to the PR: The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Not a regression. The characters in discussion was not previously added.

Determine if we should create a regression test for this bug. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

No. This is a minor case and wouldn’t we beneficial to add a regression test.

@dukenv0307 In the proposed changes, Since this is a regex change, kindly mention how you would change the regex to make this working.

Add _-=|;`~ key to both SPECIAL_CHAR_OR_EMOJI and MENTION_REPLACER regex (don’t add + key because this key maybe exist in email)

This doesn’t provide complete information on how you would like to change the regex.

@PauloGasparSv I agree we should add a lower subset of character which don’t clash with existing experiences. Even if people want to add more we can do it in future if required. (Which i highly doubt will happen)