App: [HOLD for payment 2023-06-29][$1000] Error message "Can't remove admin" isn't shown when selecting workspace admins

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. go to settings -> workspaces 2.Select one workspace
  2. go to members
  3. try on removing admin

Expected Result:

Error should show and you should be able to remove an admin

Actual Result:

Admin can almost be removed, then error message is thrown

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: main Reproducible in staging?: N Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation Expensify/Expensify Issue URL: Issue reported by: @ashimsharma10 Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686829788221639

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01b1012f509c1a5e12
  • Upwork Job ID: 1670661235088379904
  • Last Price Increase: 2023-06-19

About this issue

  • Original URL
  • State: closed
  • Created a year ago
  • Comments: 42 (27 by maintainers)

Most upvoted comments

This issue will be fixed by My proposal in another issue

Paid @Pujan92 including a bonus as per this Paid @ashimsharma10 their reporting bonus

Once the checklist is complete I’ll issue C+ payment and we can close this 🎉

@sobitneupane @MonilBhavsar PR is ready for review!

Yes, correct 👍

@Beamanator let’s add deploy blocker label to this issue and do you think we should CP the PR to staging?

Could you please prioritize this PR as this seems to be a deploy blocker and we want to fix it asap cc @sobitneupane

Thanks! Let’s use that method and pass a single login

@bfitzexpensify I’m going OOO til the 26th so just assigning someone to keep this moving. Happy to take it back next week!

@kadiealexander I would like to take C+ role here if possible.

Nope @kadiealexander. It’s a different issue.

I have reviewed @Pujan92’s proposal. It will solve this issue. We can go with @Pujan92’s proposal to solve this issue.