App: [HOLD for payment 2023-05-22] [$4000] Not showing any data on search page when press Cmd+K shortcut while loading after login
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Update network connection to Slow 3G (to reproduce easily)
- Login with any account
- While full screen loading, press Cmd+K shortcut
- Search page opens
This also applies to other pages like Profile, New chat, Send money, Workspaces, not only search
Expected Result:
- When the user launches the app and reports data is still loading, they can open the search page with
CMD+Kas usual - The search page opens, and displays a skeleton UI (just as the LHN would when it doesn’t yet have reports data)
- While the search page is loading, the options in the header are not disabled. So the user can:
- Enter a search query (still, just a skeleton UI is shown)
- Press < to close the RHP
- Tap outside or swipe to close the RHP
- If the reports load while the search page is displaying a skeleton UI, then any reports matching the search query are displayed. If there are no results matching the search query, then the skeleton UI is replaced by the standard
No results foundUI
Actual Result:
shows nothing on Search page
Workaround:
Close and re-open Search page
Platforms:
Which of our officially supported platforms is this issue occurring on?
- MacOS / Chrome / Safari
Version Number: 1.2.58-2 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos:
Expensify/Expensify Issue URL: Issue reported by: @aimane-chnaif Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1674469304602449
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~013d319d96dd608a1f
- Upwork Job ID: 1620163656058773504
- Last Price Increase: 2023-03-31
About this issue
- Original URL
- State: closed
- Created a year ago
- Comments: 70 (48 by maintainers)
@jczekalski The proposal looks good to me, please move forward with opening a PR if you haven’t already. @aimane-chnaif please still review the proposal and provide feedback if you have any. Just a reminder this issue is technically breaking WAQ so let’s collectively focus on closing it as a high priority 😄 . Thanks guys! 🙏
Assigning myself to help with this issue when Amy is ooo, we will hand this one to expert contributors given how old this issue is and breaks WAQ
Not a lot of feedback on that question, but I think it’d make sense to proceed as follows:
Moving this to weekly in the interim.
Thanks @mallenexpensify As this was agency PR, no timeline rule applied. And this is minor but I might also be eligible for reporting bonus.
@situchan sorry, we exported this issue to SWM because it was breaking WAQ since its over 5 weeks old at this point so we will have this dedicated person see the end of this issue. I hope your proposal will be accepted on the other issue!
Also note that we agreed to show skeleton similar to LHN while loading data. Edit: this comment is redundant since it’s already fully described in
Expected Result🙂But also propose solution with the root cause why not showing any data even after data fully loaded but showing after closing and opening back.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Opening any shortcut pages straight after login doesn’t show any data.
What is the root cause of that problem?
The issue is that it takes some time for all the data to be loaded before it’s displayed.
What changes do you think we should make in order to solve the problem?
We should display a loading spinner/activity indicator in those pages/sidebars/lists until the data has been fetched from the backend & is ready to be displayed.