App: [HOLD for payment 2023-05-22] [$2000] Incorrect parsing on formatted text after URL inside link
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Open New Expensify on iOS/Android/desktop
- Start a chat
- Send this message :
[click google.com *here*](google.com) - Notice the hyperlink line under * here * changes after a few seconds
Expected Result :
The word * here * should be bold and hyperlinked
Actual Result :
The word * here * is bold, but the hyperlink is removed after a few second
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- [X ] iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: 1.3.4-0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL: Issue reported by: @kerupuksambel Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1681939793066839
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01501b1626b65fa2ee
- Upwork Job ID: 1650579616656465920
- Last Price Increase: 2023-05-01
About this issue
- Original URL
- State: closed
- Created a year ago
- Comments: 64 (47 by maintainers)
sent offers to @s77rt as C+ @eh2077 as contributor @kerupuksambel $250 as reporter
Upwork job here - https://www.upwork.com/jobs/~01501b1626b65fa2ee
@s77rt @tylerkaraszewski The PR https://github.com/Expensify/App/pull/18697 to update expensify-common is ready for review. Please help to review it at your convenience, thanks!
Not overdue. We have a PR for expensify-common https://github.com/Expensify/expensify-common/pull/529
Ah, it looks like I prepared the PR a little bit earlier😄. The PR https://github.com/Expensify/expensify-common/pull/529 for expensify-common is ready for review. Please help to review it at your convenience, thanks!
cc @s77rt @tylerkaraszewski
@eh2077 I have pointed a failing case already
This can be fixed easily but shows the downside of the tags dependency. Can we improve the regex not to relay on such tags?
Oops a bad example 😅
👋
@eh2077 I see you have a proposal already, please allow me some time I will review asap.
@Christinadobrzyn I am going to unassign myself. Can you please reapply the label to assign someone else?