App: [HOLD for payment 2023-03-20] [$2000] App does not scroll to bottom when request / send money flow is done
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Open the app
- Open any report
- Scroll above (any amount of scroll is okay)
- Click on
+directly to the left of the compose back then click on request money / send money - enter any amount and click on continue
Expected Result:
App should scroll to bottom to display the latest message for request money / send money like it does for normal messages
Actual Result:
App does not scroll to bottom on request money / send money
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: 1.2.77-0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos:
Expensify/Expensify Issue URL: Issue reported by: @dhanashree-sawant Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1677491592244309
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01c3dd247c6f2c42a2
- Upwork Job ID: 1631271440692035584
- Last Price Increase: 2023-03-09
About this issue
- Original URL
- State: closed
- Created a year ago
- Comments: 39 (26 by maintainers)
Thanks @PrashantMangukiya , you’re hired! @dhanashree-sawant and @aimane-chnaif too, can you please accept the job and reply here once you have? https://www.upwork.com/jobs/~01c3dd247c6f2c42a2
Sorry guys, making this external so C+ can review the proposals, if none are good, @narefyev91 is happy to work on this
Paid @PrashantMangukiya and @aimane-chnaif $3000, inc. the 50% timeliness bonus. @dhanashree-sawant paid $250 for reporting.
Regression test steps GH created https://github.com/Expensify/Expensify/issues/271365
Regression Test Proposal
To be repeated for all platforms:
@deetergp @aimane-chnaif Do we agree 👍 or 👎
You’re welcome @PrashantMangukiya , sorry it took me a lil bit
I don’t think this is a regression which means “used to scroll before but after offending PR, started not working”. So 1-3 can be checked off. I think regression step what @PrashantMangukiya proposed is fine.
@mallenexpensify I think we should include the regression steps for this in our regular testing. @aimane-chnaif let’s get this checklist done so we can close out and can pay @PrashantMangukiya.
I don’t think any PR caused regression. I’d say this feature was missed while implementing IOU message.
Lot to unpack here.
@PrashantMangukiya thanks for the reminder of the bonus.
@aimane-chnaif , can you address these items above?
I’m assuming this is a regression and that, once the above is done, @PrashantMangukiya should be the one the propose the regression test steps that need to be updated (even though it incorrectly states @aimane-chnaif should above. Reasoning, per here we state
Offer accepted on Upwork. Should we also eligible for timeline bonus. As pr merged within 3 days. Thank you.
@mallenexpensify Let’s give the job to @PrashantMangukiya 👍
@PrashantMangukiya’s proposal looks good too me too. It’s simple solution. I was also thinking of @Ollyws’s proposal, but as long as no other usages of IOU events callback on
ReportActionsViewthan scrolling to bottom (unlike non-IOU messages), no need to subscribe and I think we are fine to go with simple solution for now.