App: [HOLD for payment 2023-03-06] [$1000] Inconsistent formatting on multi-line text
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Open staging.new.expensify.com
- Open a chat and send this :
*this is
bold text*
- Open a chat and send this :
_this is
italic text_
Expected Result:
The italic text (second chat) should be italicized
Actual Result:
The italic text isn’t italicized
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: 1.2.62-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Expensify/Expensify Issue URL: Issue reported by: @kerupuksambel Slack conversation: (https://expensify.slack.com/archives/C049HHMV9SM/p1675081190765919)
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~014df7aa17e60e5f61
- Upwork Job ID: 1623064663503052800
- Last Price Increase: 2023-02-07
About this issue
- Original URL
- State: closed
- Created a year ago
- Comments: 49 (35 by maintainers)
@neil-marcellini, @alexxxwork, sorry for the delay and thank you for the understanding I’ll be available to review the PR, updated proposal looks good to me (the code was perfect from the start, I just wanted to make sure proposal adheres to the new guidelines)
All paid, closing
Cool, I think all that remains is payment for @alexxxwork’s implementation and @eVoloshchak’s review.
Manual regression steps are not needed, but here’s the description https://github.com/Expensify/App/issues/14675#issuecomment-1439056539
@alexxxwork IMO we don’t need manual regression tests for this since we have automated tests.
@neil-marcellini all commits signed
Update: The PR is good to go but the commits need to be signed. After @alexxxwork makes those changes we should be good to go.
I asked about that in Slack here.
@neil-marcellini Thanks! Going to finish PR by tomorrow evening.
@alexxxwork I like your proposal. Please also update the Expensimark tests to assert that multi-line italics work.
@alexxxwork, awesome, your solution does resolve the issue! Could you please update your proposal following the proposal template here?