App: [HOLD for payment 2023-02-10] [$2000] Showing pointer cursor on code-block chat message instead of I-beam cursor
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Open any chat room.
- Send code-block message
test - Hover on code-block message.
Expected Result:
On code-block message should show I-beam cursor as it not performing any action. We can copy it as normal text.
Actual Result:
Showing Pointer cursor on code-block messages.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: 1.2.54-2 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos:
Expensify/Expensify Issue URL: Issue reported by: @jatinsonijs Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1673621030750769
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~014c6f096c770787e9
- Upwork Job ID: 1615834499213443072
- Last Price Increase: 2023-01-25
About this issue
- Original URL
- State: closed
- Created a year ago
- Comments: 49 (37 by maintainers)
All paid -
Regression Steps:
@s77rt Do we really need the extra
Viewinside theTouchableWithoutFeedback?@cead22 Tested
TouchableWithoutFeedbackand it works without adding extra style. We can go withTouchableWithoutFeedbackbut I have concerns with the extraView.I also notice that we have different feedback when long pressing on
codeandprewhere it’s no highlight background onpre(it’s not caused by the proposal).https://user-images.githubusercontent.com/25520267/213600957-9db6d6fc-90e8-4441-9a09-1dd994a7eb36.mov
If we use
TouchableWithoutFeedbackwithout the extraViewwe have the same feedback highlight oncodeandpre.https://user-images.githubusercontent.com/25520267/213601154-b9cf5dd5-cea1-43cb-a5f2-98d6f110fff2.mov
@cead22 @slafortune start a discussion on Slack!
@cead22 @arielgreen Let’s assign this to @s77rt and so they can get the PR ready!
Thanks, guys for the proposals!
Since this issue only occurs for the
pretag I’m inclined to add the style where it’s needed. So, I say we can go with @Prince-Mendiratta proposal. cc @cead22 @arielgreen🎀 👀 🎀 C+ reviewed!