App: [HOLD for payment 2023-01-25] [$1000] Long text strings disappear from single-line text fields when text is too long
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action performed:
- Login with any account
- Choose any single line TextInput, ie: First name, Last name, Workspace name.
- Enter the long text with multiple words, for example:
Visaocuoitroi193's Workspacethisverylongtextand save entry
Expect result:
If the full text is too long to fit in the text field, the text should be cut off and we should add a ... to show that the string continues.
Actual result:
Any words that go past the end of the text field disappear from view. (I think it’s because they are moved to a newline)
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- iOS / native
Version Number: 1.2.43-1 Reproducible in staging?: y Reproducible in production?: y Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos:
Expensify/Expensify Issue URL: Issue reported by: @hungvu193 Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1671552728713329
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01174c064be0dcafb8
- Upwork Job ID: 1611117990550892544
- Last Price Increase: 2023-01-05
About this issue
- Original URL
- State: closed
- Created 2 years ago
- Comments: 55 (47 by maintainers)
@sakluger Done https://github.com/Expensify/App/pull/7594#issuecomment-1406610314
@sakluger Sorry, I forgot to fill out the checklist. Probably from this https://github.com/Expensify/App/pull/7594.
I believe so.
That makes sense!
I’ve paid out everyone, and included the 50% efficiency bonus for the Contributor and C+ payments.
I’m not closing out the issue quite yet, since I need to make sure we update our regression tests correctly.
@yuwenmemon Should we hold this issue until the input refactor is done in this PR? I’m afraid that changing the
line-heightnow will complicate the refactoring.I will test again regarding the line height removed.
@yuwenmemon Sorry I think I misunderstood the proposals, I thought we are going to only remove the line height for iOS.
Right, that’s why, we only fix this issue for single line input.
@mollfpr I forgot to remove lineHeight inside baseTextInput in my diff, so please ignore my comment, if we go with changing lineHeight, then we can consider only apply it with singleLine TextInput, since this issue only happen singleLine TextInput.
@allroundexperts @hungvu193 @bernhardoj you can put your thoughts in here, thanks!
FYI, I updated the title and issue description to be a bit more accurate to what the issue is.