App: [HOLD for payment 2023-01-19] [$1000] Tooltip is not centered when hovering the < (back icon) on modals

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Click on the + icon to create a new IOU
Click Request Money
Enter an amount and click next
Hover over the < icon at the top of the drawer that slides out and notice the tooltip

Alternatively:

Open the app
Go to Setting 1.Go to Profile
hover on the back button

Expected Result:

The tooltip should be centered

Actual Result:

The tooltip is slightly askew

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop

Version Number: v1.2.48-2, v1.2.49-0 Reproducible in staging?: yes Reproducible in production?: yes Notes/Photos/Videos: Any additional supporting documentation

Issue reported by: @daraksha-dk Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1672817918639959

View all open jobs on GitHub

Proposal for solution is here: https://github.com/Expensify/App/issues/13940#issuecomment-1371332290

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0159b4566d0eb1cb3d
Upwork Job ID: 1611154096654839808
Last Price Increase: 2023-01-06

About this issue

Original URL
State: closed
Created a year ago
Comments: 20 (10 by maintainers)

Most upvoted comments

The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/4661
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/4661#issuecomment-1400683633
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not sure if this is necessary, this should have been caught during the initial review, it’s a visual bug

cc: @trjExpensify

eVoloshchak on Jan 23, 2023

@daraksha-dk can you comment your proposal over to this follow-up issue so we can assign it to you? Thanks!

trjExpensify on Jan 6, 2023