App: [HOLD for payment 2022-12-23] [$1000] Web splash screen does not work correctly on dev

@ShuiRuTian Please get your changes done, We have still one business day left to merge the PR for qualifying a bonus. Else we might lose it!

The new clean PR is here: https://github.com/Expensify/App/pull/13399

@ShuiRuTian I’m intrigued.

@Santhosh-Sellavel I’m willing to consider @ShuiRuTian’s proposal since I agree it seems like https://github.com/stephencookdev/speed-measure-webpack-plugin is close to EOL:

• https://github.com/stephencookdev/speed-measure-webpack-plugin/issues/187
• https://github.com/stephencookdev/speed-measure-webpack-plugin/issues/160
• https://github.com/stephencookdev/speed-measure-webpack-plugin/issues/149
• https://github.com/stephencookdev/speed-measure-webpack-plugin/issues/174

Proposal

What we need to do:

Replace speed-measure-plugin with time-analytics-webpack-plugin.

Reason:

1. speed-measure-plugin will make custom hooks of other plugins go wrong. This will cause some strange issues. I guess this issue is just caused by this reason.
2. This replacement will also fix the build speed, In my machine, the first build time is reduced from 47s to 34s, and the rebuild time is reduced from 10s to 3s. Not sure whether this is due to the correct use of the plugin or webpack could reuse some internal cache.
3. I am the author of time-analytics-webpack-plugin. I want feedback from real users. And if there is any regression, I could provide response as soon as possible. It’s win-win.

Tech details:

“tap” methods are the callback that every webpack plugin will use to do something at some time point.

speed-measure-plugin uses Proxy to take over the control of “tap” methods, so that it could measure the time.

However, the reference of Proxy object and the origin target is different. So Map and WeakMap will treat them as different key, then the value is not correct either.

time-analytics-webpack-plugin hack for such keys, so the plugin will work.

@ShuiRuTian

Please read our contributing guidelines to understand our process.

Also Refer proposing a solution to the job.

So as first step close the PR and write a proper proposal here thanks!

Not sure how viable it is, but I would love to see a proposal for an upstream fix in SpeedMeasurePlugin that doesn’t rely on a workaround like this.

@JalalMitali ~make this changes in order to reproduce.~ Please ignore this, I did not notice the word Safari. You are right I can also not reproduce the issue on safari, but this is reproducible on chrome.

diff --git a/config/webpack/webpack.dev.js b/config/webpack/webpack.dev.js
index 2a418f882..f692d2147 100644
--- a/config/webpack/webpack.dev.js
+++ b/config/webpack/webpack.dev.js
@@ -59,5 +59,5 @@ module.exports = (env = {}) => portfinder.getPortPromise({port: BASE_PORT})
             },
         });
 
-        return speedMeasure.wrap(config);
+        return config;
     });