App: [HOLD for payment 2022-12-15] [$250] BUG: Web - Console error when comment in a report is right clicked and context menu is opened - reported by @aneequeahmad

Thanks for all the detailed discussion here! After reviewing it, I think we should proceed- please move forward with the PR @aneequeahmad 👍

Payment has been sent.

I tend to agree. It looks like we have testing for reviewing and editing messages so I think we’re covered.

@aneequeahmad has been paid for reporting and fixing the issue plus the 50% bonus for merging the PR in three days.

@aimane-chnaif once you accept the offer in UpWorks I can pay you out for the contributor plus role.

Yeah I’m not sure how that works for testing. I know that reviewers/contributors should check the console to make sure there aren’t errors in places the PR directly affects… So that would have caught this in this specific case. Although actually I’m pretty sure QA has their console up while checking things. So if right clicking the context menu is part of their flow, it should be caught already? Not 100% on that…

So the PR that introduced this bug is definitely this one - none of the related code has been touched since then, and that’s when the anchor prop was created. However it’s also the PR that created the functionality in the first place, I believe, so this was less of a regression and more that testers must not have checked for the console errors?

Let me know if you agree @aimane-chnaif and @robertjchen

Merged! Awaiting deployment.

@aimane-chnaif PR has been raised.

@aneequeahmad We have two days to merge the PR for the 50% bonus to apply. Can we expect the PR tomorrow?

@AhmadbinZahid Since you are the first to propose working solution, if you can explain or share any link that explains why event.nativeEvent.target is always number on iOS (cannot be anything like string, boolean, ReactNodeArray, etc), I’d like to accept your solution.

You didn’t make me convinced on this. And your final answer is for native (which includes android), not only for iOS. And you were still asking what type of anchor is in android since you’re not sure (maybe you don’t have android device to test). We won’t apply this kind of unconfirmed solution which depend on test result without root cause.

And PropTypes.node was original definition in current codebase. You won’t able to guarantee narrowing it to PropTypes.number won’t cause any regression, correct?

@aneequeahmad’s updated proposal looks good to me.

PropTypes.node is for native, PropTypes.object is for web based platforms

cc: @dangrous

🎀 👀 🎀 C+ reviewed

Can anyone confirm what is the typeof anchor in case of android?

object

Reviewing now

@dangrous @aimane-chnaif can you both please review @aneequeahmad’s proposal?