App: [HOLD for payment 2022-12-08] [$250][Form Refactor] CompanyStep
Coming from the New Expensify Forms design doc, we should refactor CompanyStep to use the new form component, follow the guidelines below:
Here’s an example of a Form refactor: https://github.com/Expensify/App/pull/9056
Guidelines
- Replace the form component with Form.js.
- Create a unique Onyx key in ONYXKEYS.FORM and pass it as the formID prop to Form.
- Pass a validate callback prop.
- Pass an onSubmit callback prop that calls the API via an action.
- Update all inputs wrapped by Form, following the guidelines in Refactor inputs.
- Remove any unused code.
Testing
Verify that:
- UI looks as it did before the refactor
- Values can be added and edited
- Errors are highlighted correctly (input border)
- Error messages show up correctly
- Draft values are saved properly
- Form alerts are displayed correctly
- Clicking the
fix the errorslink focuses the first input with error - No duplicate submission of the form occurs (when it’s already submitting)
About this issue
- Original URL
- State: closed
- Created 2 years ago
- Comments: 80 (34 by maintainers)
this is now merged, there were some issue gettin the commits verified, but after creating a new PR this was fixed and everyine was happy
$500 seems fair to me. Let’s go with that.
there was a deploy blocker associated, but that seems to have been fixed now
@ravindra-encoresky Thanks for the proposal but it is incomplete. The
CompanyStepis a part of the step navigation, are you sure it is working fine with your changes? Also can you check the guidelines mentioned in the GH body.Still open for better proposals.
@sketchydroide @luacmartins This is supposed to be paid out today, but before that I would like to request a raise for this one. This is was held for a long time for AddressForm, and went through multiple rounds for the review. Compared to average issues, this was a bit bigger.
PR is almost merged here.
PR is reviewed, and I’ve left 1-2 comments. This should be closed very soon.
This is under review, we will be reviewing the PR over the next days, @luacmartins is OOO this week, so hopefully we will have this done and merged next week
Quick note that this is a WhatsApp Quality initiative, as standardizing these forms helps us get a handle on related bugs.
Waiting on @ravindra-encoresky to work on the feedback. Then one round of review + testing should be good to merge
This is off-hold!
I think we are still waiting?
We wait for @sketchydroide to review it and give a 🟢 to your proposal. After that you can start with your PR and yeah meanwhile you can apply to Upwork. Please refer to these contributing guidelines as well before you start writing any code.
Hope this helps.