App: [HOLD for payment 2022-11-16] [$500] ios -Conversation - Offline - `Save changes` button is disabled when opened to edit the comment for the second time

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Log in an any account
  2. Disable the internet connection in the main testing device
  3. Click/Tap on the Pencil icon to activate the edit message box
  4. Edit the message to something new and save the changes
  5. Open the message editing function again

Expected Result:

Save changes button should not be disabled as it was active in step 3

Actual Result:

The Save changes button is disabled when it was opened for the second time to edit the message

Workaround:

unknown

Platform:

Where is this issue occurring?

  • iOS

Version Number: 1.2.14-0 Reproducible in staging?: y Reproducible in production?: y Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos:

https://user-images.githubusercontent.com/93399543/195699074-432cc03e-216e-4b69-9cd5-f7e0ed3eaeda.mp4

**Expensify/Expensify Issue URL:**

Issue reported by: applause internal team

Slack conversation:

View all open jobs on GitHub

About this issue

  • Original URL
  • State: closed
  • Created 2 years ago
  • Comments: 28 (15 by maintainers)

Most upvoted comments

@eVoloshchak and @furkanuzundev have been been paid, the contract has been completed, and the Upwork post has been closed. Thanks!

@eVoloshchak and @furkanuzundev have been hired via Upwork.

@furkanuzundev

When user offline and edit a message, isOfflinePendingAction is returning true and it’s trigger needsOpacity variable.

Makes sense! I’ve tested your proposal and it is working as expected

@dangrous, @furkanuzundev’s proposal looks good to me

🎀👀🎀 C+ reviewed!