App: [HOLD for payment 2022-10-10][$500] Markdown for hyperlinks doesn't work with email addresses - Reported by Karim mostafa

👋 Happy to take care of this while Lauren is out.

Can we confirm these are the correct payments?

$500 - @aimane-chnaif for the fix $500 - @mananjadhav for C+ $250 - @Karim-30 for reporting the issue

@aimane-chnaif @mananjadhav @Karim-30 I’ve invited you to job on Upwork

Was deployed on 2022-10-03, so updated it to 2022-10-10

@aimane-chnaif reviewing this issue it seems we were due to double this job to $500 before you were assigned, but that got lost in the shuffle. This job is now $500 👍

I think skipping the text. Looks like github markdown does the same

Input Markdown:

Hi, [](email@gmail.com) is my email
Hi, [ this](email@gmail.com) is my email
Hi, [           this](email@gmail.com) is my email
Hi, [ this                ](email@gmail.com) is my email

Output:

@Karim-30 - paid! Just waiting on @aimane-chnaif now and we can close this out.

I’ll discuss with my team and get back to you

I think we’ll need to manually edit the title to hold for payment until regression period. cc @laurenreidexpensify

Looks like expensify-common is updated with another latest merge commit and this improvement is now live on staging.

Looks good to me! Thanks for updating the proposal 👍

Updated proposal:

current line:

regex: /\[([\w\\s\\d!?&#;]+)\]\(([a-zA-Z0-9.!#$%&'*+/=?^_`{|}~-]+@[a-zA-Z]+?(\.[a-zA-Z]+)+)\)/gim,

updated line:

regex: /\[(.*)\]\(([a-zA-Z0-9.!#$%&'*+/=?^_`{|}~-]+@[a-zA-Z]+?(\.[a-zA-Z]+)+)\)/gim,

current line:

replacement: '<a href="mailto:$2">$1</a>',

updated line:

replacement: (match, g1, g2) => `<a href="mailto:${g2}">${g1.trim()}</a>`,

This looks exactly same as github comment:

@mananjadhav you got the wrong person 😅

Checking the regex.