App: [HOLD for payment 2022-09-23] [$500] Update the staging App to use the staging API

I am sorry that the issue is not fully fixed here. I agree that the title suggests it should be fixed in this issue, but the proposed solution here assumes that the environment variable is properly set, and the solution is build on top of that. It was not easy to test the url of the request on the staging app, and it got missed. I would like to work on the issue created, and consider that as a regression. Thank you.

I will assign @mdneyazahmad since they had a complete proposal earlier. I am sorry @wildan-m for this, I am sure there is many more issues your help will be much appreciated.

Thank you @Santhosh-Sellavel

no worries, thanks for your feedback

fab, everyone is paid! Happy weekend! 😊

Thats what we are adding! 🎉 should be good then. Thanks! Gonna ask @mdneyazahmad to raise the PR again once the server is ready

We could have never expected this, even if we could have caught this. This is different from the problem that we are trying to address in this issue. Instead, should it as treat scope increase should pay them for the solution.

IMO it is not a different problem and there’s no scope increase, it’s right there in the problem statement and solution:

NewDot staging points to the production version of our API. This means that we miss API bugs deployed to staging, they then creep up to production and affect customers. Solution: Point NewDot staging to staging.expensify.com.

We could have never expected this, even if we could have caught this. This is different from the problem that we are trying to address in this issue.

Yes, there’s unexpected things you encounter, like race conditions or other things and we don’t say: I could’ve not expected a race condition.

IMO but this should not be treated as a regression

I am fine with this, because no one realized it, but the job this issue was asking is still not done.

Thanks you very much @mdneyazahmad!

@mdneyazahmad Thank you! We learn something new about this App everyday 😂

I would say that we should ask the contributor to fix it. Just because we did not catch it, does not mean that the job they were hired for was not really done. This is similar to when contributors ask for more payment because the issue took longer or was harder than expected. We recognize that and pay them extra. This is kind of the same but the other way around. We can all chose to say: what we agreed is what we agreed and there’s no wiggle room OR we can chose to be more flexible and recognize that these situations (issues being more complex than expected and not catching issues during review) will exist. I rather be more flexible and permissive.

@mdneyazahmad paid 🎉

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@mdneyazahmad The changes were deployed in the server, can you please raise the PR again? You can find the staging.expensify.com server in the curl output.

@NicMendonca Even though there was a regression from this PR, I would say we should not treat this agains the contributors or c+. The regression was caused by a servers settings, which we did not realize before.

@mountiny I believe this will help curl --head https://staging.new.expensify.com and it should include https://staging.new.expensify.com in connect-src CSP.

@mdneyazahmad @Santhosh-Sellavel Lets try to get this out sooner than later if possible. This is very handy feature for our QA to catch some API mistakes in staging before it hits production 🙇

Price doubled: https://www.upwork.com/jobs/~01483fb4b26ac8eba4