App: [HOLD for payment 2022-07-15] [$250] Web - Request money - Five most recent chats aren't shown correctly
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Pre-Condition: Have a couple/several chats already open with other accounts
- Access http://staging.new.expensify.com
- Log in to a high traffic account
- Click on the green “Plus” icon on the right side of chat history
- Click on “Request Money”
- Enter any amount in Big Number Pad (BNP) and any currency (For example: 1 Real)
- Click green “Next” button
Expected Result:
The user expects to see five most recent chats appear under the Recents header (Excluding group chats and concierge chat)
Actual Result:
The user sees five chats in this section, however they are not the five most recent chats. There is one chat that should not be placed within this list
Workaround:
Unknown
Platform:
Where is this issue occurring?
- Web
- iOS
- Android
- Desktop App
- Mobile Web
Version Number: 1.1.44.1
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester: applausetester+ebezerra@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:
About this issue
- Original URL
- State: closed
- Created 2 years ago
- Comments: 54 (34 by maintainers)
Congratulations @dylanexpensify ❤ . I wish your baby a happy, peaceful and healthy life ✨🎂🎉🎶 .
No need to double. we are good here.
Thanks both for your patience. I’ve issued payments in Upwork, so I’m closing out this issue. Please reach out if we’ve missed something.
@metehanozyurt Yes absolutely. Thank you so much for pointing that out. I’ve sent the updated offer (same for @parasharrajat). I’ll be on later this evening so maybe we’ll cross paths and we can close this out!
Thank you for invitation @JmillsExpensify . There was something I wanted to talk about. It was bonus for this job, I wonder if I can still get it. Thanks. https://github.com/Expensify/App/issues/8220#issuecomment-1089371957
Ah, the saga continues! Looks like the previous post from above is already expired. I’ve created a fresh one here: https://www.upwork.com/jobs/~01a80e9993680dc31b. @parasharrajat @metehanozyurt I’ve already invited you both to the job. Please accept and we’ll get this processed for you both pronto.
Issue not reproducible during KI retests. (Third week)
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.79-17 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2022-07-15. 🎊
PR was just merged today
I’m heading on parental leave so reassigning! Thank you to whoever gets assigned this! ❤️
Thank you so much all your help @parasharrajat 🙏 . I have come to the end of the study according to the new updates. I will check the tests and make a new commit .
https://expensify.slack.com/archives/C01GTK53T8Q/p1649783308226609
@metehanozyurt I think your proposal looks good, and I agree the other pages (
IOUParticipantsSplit,NewChatPage, etc…) should also sort by timestamp. I did not review the unit tests, but we can always adjust unit tests in the PR. We want them to be thorough but also readable.I would be happy to issue a $250 bonus for the increased scope, so long as unit tests thoroughly cover all new and old cases.
@dylanexpensify If we are good to hire the selected proposal then I don’t think a price increase is needed.
@metehanozyurt’s proposal looks good, but I am unwilling to approve any proposal or PR that touches
OptionsListUtilswithout also creating unit tests to cover the change.@metehanozyurt If you agree to also create unit tests, 👍 this message and I will assign you the job.
📣 @parasharrajat You have been assigned to this job by @melvin-bot[bot]! Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻 Keep in mind: Code of Conduct | Contributing 📖