App: [HOLD for payment 2022-05-24][$1000] Native Apps - There is an extra space above codeblocks in android and IOS - reported by @sobitneupane
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Send codeblock with message above and below:
Here is come code
const myLineOfCode = 'some code';
Expected Result:
Same output in all platforms.
Actual Result:
Extra space above codeblocks in android and IOS.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platform:
Where is this issue occurring?
- iOS
- Android
Version Number: 1.1.41-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Related to https://github.com/Expensify/App/issues/7496#issuecomment-1063237609
Expensify/Expensify Issue URL: Issue reported by: @sobitneupane Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1644507497800049
About this issue
- Original URL
- State: closed
- Created 2 years ago
- Comments: 48 (24 by maintainers)
@JmillsExpensify @rushatgabhane I think it’s looking good
Fantastic, thanks everyone!
🎀 👀 🎀 C+ reviewed @marcochavezf I like @aneequeahmad’s proposal.
Let’s get the party started 👯♀️
You’re good! You already applied to the existing job post here: https://www.upwork.com/jobs/~012ed1a030f60ce0f5. I’ve hired you, same for @rushatgabhane as C+ and @sobitneupane for reporting. Thanks all, let me know we still have any issues.
@aneequeahmad the job might have expired and a new one will be created.
Once the issue is not reproducible by the QA team, the payments will be settled. Thanks for understanding!
@JmillsExpensify @rushatgabhane It seems like there is still some gap and issue is repro. See below
Yeah, it’s interesting that
expensify-commonwas eventually updated in E/App because of another PR. Thanks for testing again on Android @rushatgabhane!Sure, sounds like a good plan to me! I already sent a message to the QA team to test again.
Interesting…
Looks like @aneequeahmad’s changes to
expensify-commonhit production 3 days ago because of an another PR https://github.com/Expensify/App/pull/8948, which updatedexpensify-commonto a more up-to-date version.If @marcochavezf agrees with me as well, we can ask the QA team to test this issue and close it out in 7 days.
@JmillsExpensify Applied, yeah sounds good let’s wait for the regression period. Thanks for your message.
cc @sobitneupane and @rushatgabhane as well for the new job posting.
No worries. I’ve got you covered here: https://www.upwork.com/jobs/~012ed1a030f60ce0f5. Can you apply? Then we can issue payment once the standard regression period ends.
Thanks @marcochavezf! Looks like we have a couple of updates in the linked PR.
Commented in the PR, the eslint error is thrown by the escape
\character, which is not needed inside of[ ]in JS in this caseAlso, I think the price should be doubled ($2000) hehe, as I have pointed out another bug in the already written code and fixed that too. Let me know if it makes sense or not(I read somewhere if I feel like the price should be increased I should mention it in the comment).
cc: @marcochavezf
Applied on Upwork, PR is raised for Expensify-common.
cc: @marcochavezf, @rushatgabhane
@rushatgabhane Circling back on this one because we owe feedback for this proposal. Thanks!