App: [HOLD for payment 2022-04-20] [$250] Attachment - Newly uploaded MP4 file removing attachment tag after refresh the page

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to https://staging.new.expensify.com and log in with any account
  2. Click to add attachment
  3. Select mp4 video and tap Send
  4. Refresh the page

Expected Result:

~Newly uploaded MP4 file should show mp4 tag~

Any attachment should show up as [Attachement] right after being uploaded.

Actual Result:

Newly uploaded MP4 file removing attachment tag after refresh the page

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.46.3

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): rpriyo@gmail.com

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/93399543/160263780-3e177791-46ce-496e-ac1d-ce297612a2ba.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause (Exploratory)

Job Post: https://www.upwork.com/jobs/~01ffc5a7c850c6ac3a

View all open jobs on GitHub

About this issue

  • Original URL
  • State: closed
  • Created 2 years ago
  • Comments: 38 (27 by maintainers)

Most upvoted comments

Hi @dennismunene , apologies for the delay, I was on vacation. Just sent you an offer. @parasharrajat invited you to the job for C+ as well.

Paid @dennismunene , thanks. @parasharrajat can you accept the offer for the job and I’ll pay out for c+?

Issue not reproducible during KI retests. (Second week)

Issue not reproducible during KI retests. (First week)

@mountiny Yes the proposal covers this , all attachments will be represented as [Attachment]

Oh, I missed clarifying the Expected section too. I assumed we want to always show the [Attachement] for any type of attachment which the proposal does, right?

I will update the body of the issue.

@mountiny @parasharrajat I double checked sending links , This does replace links after a few seconds. I’ve updated my proposal with the appropriate fix. Only a tags with this prop data-expensify-source should be considered attachments.

Feel free to submit the PR @dennismunene, thank you for the proposal and thanks @parasharrajat for the review!

I am surprised that the normal links work fine, hopefully, it will work well once tested.