App: [HOLD for payment 2022-03-17] [$1000] Report a bug does not lead to Concierge - Reported by Hitesh

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

1 - Login app 2 - Goto any report and get back 3 - Goto Settings -> about -> click on Report a bug

Another scenario 1 - Click settings > Workspace 2 - Click on the Book travel row from the workspace editor 3 - Click on Book travel with Concierge

Another scenario 1 - Open app and login 2 - Go to Settings and choose any workspace 3 - Tap Get assistance 4 - Tap Chat with Concierge

Expected Result:

User should have been navigated to “Concierge” report chat

Actual Result:

User is navigated to the previous active report.

Workaround:

Unknown

Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: 1.1.23 -0 Reproducible in staging?: Y Reproducible in production?: Y Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/43995119/147522069-5bd751e4-4362-4336-9751-d05432002f0b.mov

Expensify/Expensify Issue URL: Issue reported by: @hiteshagja Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1640095164440200

View all open jobs on GitHub

About this issue

Original URL
State: closed
Created 3 years ago
Comments: 46 (38 by maintainers)

Most upvoted comments

I am tackling the navigation issues one by one as it is possible one indirectly solves the other. Thanks for your patience.

parasharrajat on Feb 2, 2022

sorry, @K4tsuki I will delete this commit. sorry again bro.

ahmdshrif on Feb 1, 2022

@ahmdshrif I am really sorry if my words hurt your feelings.

I really believe you are making the proposal yourself and I didn’t mention you are copying my proposal. I don’t even have a slightest doubt in my mind that you are making proposal yourself.

I just said it is similar but it is up to the reviewer do judge the proposals. Once again I am really sorry if my words hurt your feelings.

K4tsuki on Feb 1, 2022

@mountiny his proposal is similar to my proposal.

K4tsuki on Jan 31, 2022

Hmm, there are no new proposals with considerable differences. @hiteshagja 's proposal solves the problem but he has not justified his reasoning.

I am not able to test one of the scenarios from the reproduction steps but it works for the rest two. I will discuss the best approach to advance on this issue.

parasharrajat on Jan 23, 2022

Added another case where the Book Travel button does not redirect to the Concierge DM

thienlnam on Jan 11, 2022

PR has been merged.

mountiny on Feb 25, 2022

@Christinadobrzyn that’s correct upwork profile.

hiteshagja on Feb 24, 2022

📣 @hiteshagja You have been assigned to this job by @mountiny! Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

MelvinBot on Feb 23, 2022

This is the current item on my list https://github.com/Expensify/App/issues/7363 so soon I will update you.

parasharrajat on Feb 16, 2022

Still holding this… Handling navigational issues one by one.

parasharrajat on Feb 8, 2022

@parasharrajat

My proposal we discuss on 4612 issue solve this also https://github.com/Expensify/App/issues/4612#issuecomment-1024489080.

and I think will solve many navigation issues.

ahmdshrif on Jan 29, 2022

Proposal:

Dismissing the modal will fix this bug like so :

https://github.com/Expensify/App/blob/0bce09177d2aed8c5e377bc758f5241dd22886eb/src/pages/settings/AboutPage/index.js#L58

    action: () => {
                Navigation.dismissModal(true)
                Report.navigateToConciergeChat();
            }

brianmuks on Jan 22, 2022