App: [HOLD for checklist] [$1000] Dev: console error on attach large file

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Go to any chat
Send large file (<24 MB)

Expected Result:

Should not show any console error

Actual Result:

Console error appears (Failed prop type: The prop title is marked as required in ConfirmContent, but its value is null.)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop

Version Number: 1.3.34-1(occurs in dev) Reproducible in staging?: n/a Reproducible in production?: n/a If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/93399543/f01b8478-336a-495a-af7b-b0cd7d5b3982

Expensify/Expensify Issue URL: Issue reported by: @gadhiyamanan Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688026830153149

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~019cbb5ba4f7a22f2f
Upwork Job ID: 1676868760224428032
Last Price Increase: 2023-07-06

About this issue

Original URL
State: closed
Created a year ago
Comments: 32 (19 by maintainers)

Commits related to this issue

Add error message for image being too small — committed to Expensify/App by tgolen 2 years ago

Most upvoted comments

Payment complete. Awaiting checklist from @narefyev91

greg-schroeder on Jul 21, 2023

The issue here is that Confirm modal is not really waiting null for title. In all other components in which <ConfirmModal is used - we either directly apply title from props, or having default value as empty string - like here src/components/AvatarWithImagePicker.js The correct solution is to have default empty string - @gadhiyamanan was the first one - his proposal looks good https://github.com/Expensify/App/issues/21947#issuecomment-1614554434 🎀 👀 🎀 C+ reviewed

narefyev91 on Jul 6, 2023