App: [HOLD FOR #26538][$500] Web - Date/Merchant is disabled for split, but still accessible with deeplink
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Click plus button => Split, enter amount, press Next.
- Choose few members, press Next.
- At Confirmation Page, change the link from
/split/new/confirmation/to/split/new/date/or/split/new/merchant/ - Notice these pages are accessible.
Expected Result:
Merchant and Date shouldn’t be accessible through deeplink
Actual Result:
Merchant and Date are accessible through deeplink
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: 1.3.70.5 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/875654cc-1a74-4e9c-a816-2cc736900fb9
https://github.com/Expensify/App/assets/93399543/5590bf53-9212-40a3-af8f-3f5a0eb2ee58
Expensify/Expensify Issue URL: Issue reported by: @hungvu193 Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694749185834509
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01c67f584444b66580
- Upwork Job ID: 1702782136315203584
- Last Price Increase: 2023-10-06
About this issue
- Original URL
- State: closed
- Created 10 months ago
- Comments: 42 (26 by maintainers)
We’re having a bit of a discussion in this thread about a broader solution to the issue of using a direct link to go to a specific page on a form that you shouldn’t be able to access without filling in prior info: https://expensify.slack.com/archives/C049HHMV9SM/p1695064187785649?thread_ts=1694439235.983099&cid=C049HHMV9SM
@bfitzexpensify, personally, I think it’s okay to display “it’s not here” if the page is not accessible (i.e., @rayane-djouah’s proposal). Do we need to confirm this expected result with the design team again?