App: [HOLD #37281][$1000] Onyx data does not get removed cleanly on sign out

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: Reproducible in staging?: needs reproduction ( Don’t have account with several hundreds of chats) Reproducible in production?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @marcaaron Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1705012041676559

Action Performed:

  1. Signed into an account with many many chats
  2. Signed out
  3. Signed in with a brand new account (which should have only the Concierge chat)

Expected Result:

Nothing from the account that I signed out from should be persisted in the client data whatsoever.

Actual Result:

Tons of chats from the first account show up in the second account. A ton of Onyx keys still have values of {hasDraft: false} and there are also straight up reports that shouldn’t be there at all. These also show up in the LHN.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence 2024-01-11_12-21-12 2024-01-11_12-22-20

2024-01-11_12-19-23

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01211aa8ecc46d7a5e
  • Upwork Job ID: 1759703332875366400
  • Last Price Increase: 2024-03-24

About this issue

  • Original URL
  • State: closed
  • Created 6 months ago
  • Comments: 73 (42 by maintainers)

Most upvoted comments

Throwing retest-weekly on this to confirm, then we can close. thx!

Put on hold, removed External and Help Wanted, bumped to Weekly

Thanks @shubham1206agra for the tip!

@waseemAnsari11011 This solution was already suggested by @tienifr and we don’t want to go with that approach because it’s a workaround (not fixing the root cause).

PS: When submitting a proposal please follow the proposal template.

Thanks @tienifr, great writeup! I hope you don’t mind - I went over your proposal and made some minor grammatical edits. Agree with @s77rt that you should post it in #expensify-open-source, and I look forward to hearing what people think.

Yes @hayes102 , please keep in mind this from our CONTRIBUTING.md

Note: Before submitting a proposal on an issue, be sure to read any other existing proposals. ALL NEW PROPOSALS MUST BE DIFFERENT FROM EXISTING PROPOSALS. The difference should be important, meaningful or considerable.

Thanks @s77rt , I updated to External and removed Needs Reproduction because you were able to reproduce above.

Please reassign. I am planning to go OOO.