App: [HOLD] [$250] The green dot disappears after the admin has approved but not yet paid

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.59-3 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @DylanDylann Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1712137559164489

Action Performed:

Pre-requisites:

  1. Have a collect WS and make chat enabled on ND

  2. Have 2 accounts (one admin, one employee)

  3. Having `Make or track payments enabled

  4. Toggle off Add approvals

  5. [Employee] Request money from the workspace chat and submit it

  6. [Admin] approve the above request

Expected Result:

The green dot should be appear after the admin has approved but not yet paid

Actual Result:

The green dot disappears after the admin has approved but not yet paid

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/38435837/821175c0-2070-42db-ac97-c0753503d256

https://github.com/Expensify/App/assets/38435837/53e2028a-683f-4d01-b602-567a83af1223

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ebb3d2379b3cb18b
  • Upwork Job ID: 1777701518072827904
  • Last Price Increase: 2024-04-09
  • Automatic offers:
    • DylanDylann | Reviewer | 0

About this issue

  • Original URL
  • State: open
  • Created 3 months ago
  • Comments: 23 (14 by maintainers)

Most upvoted comments

Nice idea, but I think we shouldn’t. It could be months before the backend fix is made, and in the meantime lots of things could have changed or altered the eventual implementation. lets keep the offline/online code aligned.

I’ve added it to wave collect, thank you Jules - no problem

https://github.com/Expensify/App/assets/161821005/2f32e9e2-8219-4958-9bd3-949c9699a13c

We have draft PR here, but we still need to change Back End. Because it’s return hasOutstandingChildRequest=false when we call api ApproveMoneyRequest @Julesssss please help to update on BE side cc @DylanDylann