App: [HOLD #11768] [$8000] The Back ⌘[ and Forward ⌘] shortcuts keys are not working as expected when navigating via RHN (Right Hand Navigation)

[BELOW IS THE PROCESS OF BEING EDITED/UPDATED AND IS ON HOLD]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Breaking this off from https://github.com/Expensify/App/issues/4612, that issue will be focused solely on LeftHandNav (LHN) and this one is for the navigation in RHN (or RHP - Pane)

Action Performed:

Open the app on the Web or desktop.
Open Search/Chat Switch (⌘+k shortcut)
Navigate to some chat P.
Open the Search Page again and navigate to some chat Q.
Open the Search Page again and navigate to some chat R.
Open the Search Page again and navigate to some chat Q.
Use the back ⌘[ and Forward ⌘] shortcuts to go to previous and forwards chats respectively.
You can navigate to any number to chats.

Expected Result:

When we open reports from RHN, Back ⌘[ and Forward ⌘] shortcuts should work and navigate through the previously navigated conversations in the main/focused chat view. ie. if I visit chats with Joanie, Alex then Daniel, I expect ⌘[ to take me from my chat with Daniel back to Alex then ⌘[ again back to Joanie. Most-everywhere else the back/forward actions follow a standard flow.

RHN contains navigating via Search Page, New Chat Page, or any other modal.

Back ⌘[ and Forward ⌘] shortcuts should work and navigate through the previously navigated conversations in the main/focused chat view. ie. if I visit chats with Joanie, Alex then Daniel, I expect ⌘[ to take me from my chat with Daniel back to Alex then ⌘[ again back to Joanie. Most-everywhere else the back/forward actions follow a standard flow.

Actual Result:

Shortcuts are not working as expected.

Workaround:

User has to manually navigate through the conversations. ie. If using keyboard navigation you always have to ⌘k, start typing a name, then return to navigate

Platform:

Where is this issue occurring?

Desktop App

Version Number: Version 1.1.57-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation Unable to get a video atm. Will update with video later. Other job for LHN navigation issue https://github.com/Expensify/App/issues/4612

Expensify/Expensify Issue URL:

View all open jobs on Upwork

From @mallenexpensify https://expensify.slack.com/archives/C01GTK53T8Q/p1628722621224600

The Back ⌘[ and Forward ⌘] shortcuts keys don’t work properly on Desktop Version 1.0.82-7

About this issue

Original URL
State: closed
Created 2 years ago
Comments: 53 (31 by maintainers)

Most upvoted comments

Want to put this on hold for now then @marcaaron , @NikkiWines , @parasharrajat ?
I think we want navigation to work correctly, it makes since to come up with a holistic plan. Having he Navigation project will be helpful for organizing

mallenexpensify on May 25, 2022

Pretty concerned by this issue and others related to navigation. It seems like a colossal waste to invest this much time, energy and money on temporary hacks. I’m not sure we should invest in our custom actions anymore without taking a more serious look at all the navigation issues we are experiencing and coming up with a holistic plan to solve them.

marcaaron on May 18, 2022

I am confused by the description of this issue. I will confirm the expected behavior here and get back to you guys. For now I am taking back my reviews cc: @mdneyazahmad

parasharrajat on Apr 24, 2022

It is js coding issue i can fix it easy

Salehmrcp on Apr 16, 2022

That sounds good to me. I have a lot of thoughts regarding:

How the current navigation works (very messy in spots)
Whether it is something that can be proposed as a feature to react-navigation or not
If not, whether we can develop a solid custom navigator to get around issues and design it with a particular wish list in mind - hopefully with some insight and feedback from the maintainers
Which direction is right for us in the long term?

It’s a good time to step back and reflect on these I think.

marcaaron on May 25, 2022

Can we please fix all of these issues in react-navigation?

marcaaron on May 18, 2022

Thanks @parasharrajat , took off hold, added Help Wanted label and created a new Upwork job. Let’s leave at $8k for a bit while you continue to review proposals Rajat . https://www.upwork.com/jobs/~018d0820ec4f3aaef7

mallenexpensify on May 17, 2022

I am sorry @metehanozyurt I was unaware about the this feature (we can see edited history).

mdneyazahmad on Apr 24, 2022

ofcourse @mdneyazahmad it can be visible first proposal and edited version(“video upload”). both version before your last message. When i see your commit after upload image i didnt touch anything. Sorry for the time conflict. I was also looking. Thank you

metehanozyurt on Apr 24, 2022

@Salehmrcp, per the guidelines here you need to do the following:

After you reproduce the issue, make a proposal for your solution and post it as a comment in the corresponding GitHub issue (linked in the Upwork job). Your solution proposal should include a brief technical explanation of the changes you will make.

NikkiWines on Apr 18, 2022

@Salehmrcp Can you post a proposal? Please look at CONTRIBUTING.md for more.

parasharrajat on Apr 18, 2022