App: Errors in ONYXKEYS.USER_WALLET getting cleared instantly without user interaction

Regression coming from: https://github.com/Expensify/App/pull/10447/files#r1017060491

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

Have a user with 2 bank accounts

  1. Go to /settings/payments in new dot
  2. Click the bank account that is not your Default image
  3. Click “Make default payment method”
  4. Input a bad password

https://user-images.githubusercontent.com/87341702/200663920-ab6260ae-6260-4a2d-a6a7-df06eb1f0cb5.mov

Expected Result:

There will be an error below the “Add payment method” button, the error should stay there until you click the X

Actual Result:

The error appears below the “Add payment method” button, but gets immediately removed

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: Reproducible in staging?: Reproducible in production?: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation Expensify/Expensify Issue URL: Issue reported by: Slack conversation:

View all open jobs on GitHub

About this issue

  • Original URL
  • State: closed
  • Created 2 years ago
  • Comments: 24 (20 by maintainers)

Most upvoted comments

Kinda looks like a decent amount of people are still unclear how this works 😄 https://expensify.slack.com/archives/C01SKUP7QR0/p1668104342206089 (cc @michaelhaxhiu )

hehe, I’m a bit lost too, but I think:

  • @thesahindia should be assigned to this issue because he is the C+ that reviewed the PR
  • An Upwork job posting should be created to pay @thesahindia

@Beamanator is this correct?

@thesahindia has been paid in Upwork. I believe we can close!

Cool - the PR has been merged right @aldo-expensify? Can we consider this bug fixed?

@thesahindia - can you apply in Upwork so that we can pay you for reviewing the PR?

@lschurr, done!

@lschurr I requested a test to be added/updated for it here: https://github.com/Expensify/Expensify/issues/241841

@lschurr I’ll take care of it internally, I know already where the bug is 😃