App: Edit command is slow

Context https://expensify.slack.com/archives/C03TQ48KC/p1671566294965399

Problem

UpdateComment and really Report_EditComment too (they use the same code) are slow. Mostly, it is caused by fully loading and instantiating all the report history.

Solution

Instead of loading the whole history, to then call ReportUtils::getMostRecentVisibleAction and ReportUtils::getMostRecentVisibleUnreadAction, we should have auth return those values by querying them directly in the DB and only returning the data we need.

BTW this will not be fixed by the deprecate sequence numbers project, so it needs to be done separately.

cc @chiragsalian

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~016ec925fa79763af8
  • Upwork Job ID: 1605317751109066752
  • Last Price Increase: 2022-12-20

About this issue

  • Original URL
  • State: closed
  • Created 2 years ago
  • Comments: 60 (35 by maintainers)

Most upvoted comments

Waiting for reviews

Auth PR seems to be close to being done with the comments