App: [Awaiting Payment 11th Jan] [$500] Chat-"Hmm... it's not here" appears after clicking Previous arrow from an attachment preview

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.3.97-1 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause-Internal Team Slack conversation: @

Action Performed:

Create a request with a receipt via Request Money > Scan` (if you don’t have one already)
Navigate to the IOU report
Add an attachment to the IOU report via + > Add attachment
Click on the uploaded attachment
Tap the < arrow in the attachment carousal
Observe the “Hmm it’s not here” page

Expected Result:

The uploaded receipt can be seen in the attachment carousal modal

Actual Result:

The uploaded receipt can not be seen and “Hmm… it’s not here” appears after clicking the < navigation arrow from an attachment preview

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/115492554/164a045a-46d9-456a-b924-8f036c45703c

Bug6269678_1699519179590!Receipt_preview_hmm_its_not_here

Bug6269678_1699519463833!IMG_20231109_114404

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01a232fe720233dddb
Upwork Job ID: 1722561095734079488
Last Price Increase: 2023-11-09
Automatic offers:

dukenv0307 | Contributor | 27703336
shubham1206agra | Contributor | 28051420

Issue Owner

Current Issue Owner: @trjExpensify

About this issue

Original URL
State: closed
Created 8 months ago
Comments: 83 (60 by maintainers)

Most upvoted comments

@trjExpensify The current check now is used for transantion report so it works fine. parent action of transaction report will be a iou action that contain transactionID in originalMessage.

dukenv0307 on Nov 9, 2023

yes correct. @dukenv0307 should take responsible for fixing it. And then I don’t suggest to apply regression penalty given the efforts they made to fix this issue so far (just my suggestion)

situchan on Dec 21, 2023

@trjExpensify The problem here is if we don’t send any attachments in IOU report, we don’t have a way to open the receipt image of the transaction, that creates an inconsistency because we can only open it by opening another attachment while in the transaction thread report we can open reciept image by clicking to this image.

I see. I think the expected behaviour of tapping the request preview component in the iou/expenseReport should still be to open the request thread not an attachment preview. So I think I see what you’re saying…

If the iou/expenseReport does not have an attachment, there’s nothing to launch the carousal to cycle the receipts attached to the requests on the report.
If the iou/expenseReport has an attachment, you can preview that attachment and then the carousal will cycle attachments and receipts.
That’s somewhat inconsistent behaviour to launch the carousal, as it’s only possible when an attachment is uploaded to the iou/expenseReport.
So are we 1) okay with that? or 2) do we not include receipts in the carousal when accessible. If we opt for 2, should we make that consistent with the transaction thread, such that only attachments in the transaction thread are included in the carousal?

trjExpensify on Nov 13, 2023