App: [$500] Web - LHN - New workspace option disappear for few seconds when switching from offline to online

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. delete All workspace if already created
2. Click on + icon to open options
3. Go to offline
4. Go back to online

Expected Result:

Anytime there are no workspaces stored in Onyx, let’s show the New Workspace option, it doesn’t matter if the user is online or offline. So we need to change the check we’re executing to consult Onyx instead of checking if you’re online or syncing.

Also, if we remove the option, we need to adjust the popup height.

Actual Result:

New workspace option disappear for few seconds

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.23.7

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/93399543/35287241-87e5-48c9-bcfe-066f6fa7888b

https://github.com/Expensify/App/assets/93399543/9ce1c7d3-6435-4ccb-8d92-92869b8aca64

Expensify/Expensify Issue URL:

Issue reported by: @gadhiyamanan

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685777468247679

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b47074fb0087cc4a
• Upwork Job ID: 1666545539781529600
• Last Price Increase: 2023-06-23