App: [$500] [Wave 6: Workspace Chat] Scheduled Submit set to Manually creates blank report header

Slack conversation: https://expensify.slack.com/archives/C02MW39LT9N/p1703188880908729?thread_ts=1703187017.215259&cid=C02MW39LT9N

Action Performed:

Pre-testing requirement: Collect workspace type with the isPolicyExpenseChatEnabled NVP set (SO).

  1. As the admin, go to OldDot and change the scheduled submit frequency to manually for a workspace
  2. Make sure the workspace has at least two members (who’s NewDot accounts you’ll use)
  3. Log back into NewDot as the Member (or refresh if you already are in another window)
  4. Create a Request Money to Admin
  5. As the Admin > Verify that the LHN row for the workspace chat includes a GBR green dot for the draft report awaiting submission ✅
  6. As the Member > Tap the workspace chat row to navigate to the workspace chat view • Verify that the draft report preview component appears in the workspace chat ✅ • Verify that the draft report preview component in the chat: • Verify the IOU includes a green Submit button ✅
  7. Tap the report preview component of the second draft report to navigate to the expense report view • Verify that a banner is in the page header with the label Next steps ❌ • Verify that the next steps text matches the manual submission cadence you set on the paid policy. E.g “Waiting for %displayName% to submit expenses.” ❌ • Verify that a green Submit button is in the page header beneath the “Next steps” banner ❌

NOTE: This does eventually update - it’s just not immediate

image

Expected Result:

Next Steps should reflect the Manually frequency “waiting for [employee] to submit expenses” There should be a Submit button

Actual Result:

The “next steps” wording doesn’t reflect a Manually frequency There’s no Submit button

Screenshots/Videos

https://github.com/Expensify/App/assets/51066321/376df7e9-6074-4a0b-b749-db8718b5218d

image

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c51092024bd72e04
  • Upwork Job ID: 1742346576004784128
  • Last Price Increase: 2024-01-03

About this issue

  • Original URL
  • State: closed
  • Created 6 months ago
  • Comments: 15 (5 by maintainers)

Most upvoted comments

the issue is that the settings on the Request Money Draft do not match the “Manual” frequency, they still match the “weekly” frequency.

@Christinadobrzyn @fedirjh I just checked with Manual frequency and the message in OD still shows the Weekly message (notice attached screenshot) I think this needs to be addressed in BE first. And, if there is any follow-up work required in FE, we can do it.

Screenshot 2024-01-03 at 1 32 31 PM

Screenshot 2024-01-03 at 1 40 06 PM