App: [$500] Wallet - "Delete Bank Account" button is positioned incorrectly
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.36-0 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
Action Performed:
- Open Desktop App or go to staging.new.expensify.com
- Login with any account
- Go to Settings > Wallet
- Tap ‘Add bank account’ > ‘Personal Bank Account’ and follow the flow
- Tap to added in step 4 bank account
- ‘Delete’ button appears
Expected Result:
- Add the vertical three dots to the right-side of each bank account row to access the overflow menu
- Clicking the row reveals the popover (bottom drawer on mobile) beneath the three dots icon, containing the two menu items to make default (if applicable) or delete the bank account
- When the overflow menu is expanded, the three dots are green.
- Choosing to delete the bank account closes the menu and a centred alert modal appears to confirm the action.
- Update the badge component so that it matches the new styles, and applied here for
Default
:
P.s ignore the wider redesign of this page you can see in these mocks, we’re taking care of that elsewhere as a v2.
More discussion here in thread.
Actual Result:
The button ‘Delete’ is NOT aligned with the user interface elements and we use inconsistent patterns on this page.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/93399543/51649e90-a74f-4150-99c0-d95ae9862791
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~0180de917d0294db30
- Upwork Job ID: 1754563551786045440
- Last Price Increase: 2024-02-05
About this issue
- Original URL
- State: closed
- Created 5 months ago
- Comments: 23 (19 by maintainers)
Hey! I’m Jakub Szymczak from Software Mansion, an expert agency, and I’d like to work on this issue! Was called out on slack thread and doing redesign of WalletPage so it would save me some conflicts if I do it along with redesign 😄
Ah yeah, that’s a good point. Cool, assigning this to you. Can you link the PR (when ready) to this issue and the broader redesign one? Cheers!
Left a teeeny tiny comment for ya in Figma about the location of the popover, but otherwise this looks good to me!
I think we could demote this to NAB, but I’ll leave it up to @francoisl