App: [$500] Upgrade OnFido SDK to 8.0.0

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Expected Result:

Please update the Onfido UI SDK and Onfido React Native SDK in E/App

### Fixed in 6.20.1

- Public: Fix useLiveDocumentCapture onComplete not working (cross device capture `variant` missing)

Actual Result:

OnFido SDK isn’t updated to the latest.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround? Yes.

Platform:

Where is this issue occurring?

  • Web

Version Number: Expensify/Expensify Issue URL: https://github.com/Expensify/Expensify/issues/206694

View all open jobs on GitHub

About this issue

  • Original URL
  • State: closed
  • Created 2 years ago
  • Comments: 30 (20 by maintainers)

Most upvoted comments

Sorry for the confusion on this GH @jayeshmangwani and @Regaron, we are closing this external job and will fix this internally instead. Thanks for your interest, feel free to browse other available jobs here

@jayeshmangwani is right, this is now 8.0.0. Updated the issue title and our internal tracker.

We can have a contributor update Expensify/App, but if we want to bump the SDK versions in Web-Secure that will need to be Internal. Seems they do not need to be updated at the same time or by the same engineer.

suggestion:

  • Leave this External and ask for Onfido UI SDK + Onfido React Native SDK to be updated in App
  • Open a new issue in E/E to update the Web-Secure repo

There is no C+ on this issue since Rushat un-assigned himself, so I’m triggering re-assignment.

@marcaaron thanks for the guidance 🙏 I repurposed https://github.com/Expensify/Expensify/issues/206694 in E/Expensify to be for web-secure, and will keep this GH as-is for E/App.

Where does it need to be upgraded? Everywhere or only New Expensify?

I just searched for where we’re using the package, and it looks like it’s in Web-Secure in addition to App. So perhaps this should stay internal after all?

Agree this can be External as it’s just updating a library. But the flow needs to be tested still so maybe we can make sure QA is done correctly and there are no regressions after updating.