App: [$500] [HOLD for payment 2023-09-29] Follow ups to the Edit Money Request

Follow ups to the API PR https://github.com/Expensify/Web-Expensify/pull/38252 and App PR https://github.com/Expensify/App/pull/23703 related to https://github.com/Expensify/Expensify/issues/295091.

  • Update the optimistic data to re-evaluate the iou report total correctly if the currency if all the requests is same
  • Enable the currency edit option cc @koko57
  • Discuss the messages for the various types of modifiedexpense, should we remove the previously part if comment was empty
  • Auto focus the description field https://github.com/Expensify/App/pull/23703#discussion_r1290423374
  • Noting from internal issue - lets also translate the modified expense messages https://github.com/Expensify/App/issues/26369
  • Update the header styles for when editing in offline mode to give correct feedback
  • Update styles of the non-editable header to not look as disabled
  • Add the verification checks from the EditRequestPage which make sure that something actually changed to some helper method in the IOU.editMoneyRequest
  • Handle the red brick road better
  • Do not allow setting future dates
  • Make sure admins can edit the transactions logs
  • Add tests to the jest suite for IOU when editing IOU requests and expense reports too
    • you can only edit your own transactions in case of IOU
    • admins can also edit the transactions made by employees
    • correct expense/iou report totals are computed
    • https://github.com/Expensify/App/issues/26366 will be handled here
  • https://github.com/Expensify/App/issues/24623
  • User which is not able to edit the request can access the form when directly visiting the edit url. On EditMoneyRequest page, lets evaluate on first render if the user can edit and if not, lets show Hmmm its not here page or close the modal, whatever is better
  • https://github.com/Expensify/App/issues/25931
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01778206bdcc3370d6
  • Upwork Job ID: 1709801140497133568
  • Last Price Increase: 2023-10-05

About this issue

  • Original URL
  • State: closed
  • Created a year ago
  • Comments: 48 (37 by maintainers)

Commits related to this issue

Most upvoted comments

@allroundexperts Could you help summarize the payments here please, its been a long issue, thanks!

@allroundexperts Do you wanna take it on for $500 for that PR? if so, please feel free to raise a PR, no need for a proposal here. @BeeMargarida could then on the other hand review the PR of yours 😄

I have created this internal issue https://github.com/Expensify/Expensify/issues/309777 to handle the updates to the backend command to keep this issue more focused on frontend

Thank you! Would you be able to base on top of this PR and work on enabling the currency edit? https://github.com/Expensify/App/pull/23703