App: [$500] [Form Refactor] AddPlaidBankAccount
Coming from the New Expensify Forms design doc, we should refactor AddPlaidBankAccount to use the new form component, follow the guidelines below:
Here’s an example of a Form refactor: https://github.com/Expensify/App/pull/9056
Guidelines
- Replace the form component with Form.js.
- Create a unique Onyx key in ONYXKEYS.FORM and pass it as the formID prop to Form.
- Pass a validate callback prop.
- Pass an onSubmit callback prop that calls the API via an action.
- Update all inputs wrapped by Form, following the guidelines in Refactor inputs.
- Remove any unused code.
Testing
Verify that:
- UI looks as it did before the refactor
- Values can be added and edited
- Errors are highlighted correctly (input border)
- Error messages show up correctly
- Draft values are saved properly
- Form alerts are displayed correctly
- Clicking the
fix the errorslink focuses the first input with error - No duplicate submission of the form occurs (when it’s already submitting)
About this issue
- Original URL
- State: closed
- Created 2 years ago
- Comments: 19 (11 by maintainers)
Ok sounds good! Feel free to take it.
@luacmartins I understand this issue is on hold. Just leaving a comment expressing my interested in this task. I believe my relevant experience doing
Formimplementation in theProfilePagecan prove useful while doing this refactor.This comment will share updates with me over email, but would be helpful if you can let me know when this issue is ready to work on and if I can take this up! 😃
This issue is being put on hold because of push to page discussion, as per this comment.