App: [$500] `deployBlocker.yml` Workflow fails when an issue has a `'` in the title

Problem

This line can fail when a GitHub issue has a ' in the title and it has the deploy blocker label applied to it: https://github.com/Expensify/App/blob/c00b84026a590cb2b118d7e5c3ae68a7ba2ce286/.github/workflows/deployBlocker.yml#L35

It creates the following error:

Failing workflow

Run 8398a7/action-slack@v3
  with:
    status: custom
    custom_payload: {
    channel: '#expensify-open-source',
    attachments: [{
      color: "#DB4545",
      text: '💥 We have found a New Expensify Deploy Blocker, if you have any idea which PR could be causing this, please comment in the issue: <https://github.com/Expensify/App/issues/3159[2](https://github.com/Expensify/App/actions/runs/6936763631/job/18869531998#step:4:2)|"Desktop - Reload - ''Hmm... it's not here'' when reloading the desktop app">',
    }]
  }
  
    author_name: 8[3](https://github.com/Expensify/App/actions/runs/6936763631/job/18869531998#step:4:3)98a[7](https://github.com/Expensify/App/actions/runs/6936763631/job/18869531998#step:4:7)@action-slack
    github_token: ***
  env:
    GITHUB_TOKEN: ***
    SLACK_WEBHOOK_URL: ***
Error: Unexpected string

Solution

Fix the bug so it does not error. Possibly we need to escape the ' or remove these characters from the title.

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0110e529d76a12411d
Upwork Job ID: 1729227118965649408
Last Price Increase: 2023-11-27

About this issue

Original URL
State: closed
Created 7 months ago
Comments: 15 (4 by maintainers)

Most upvoted comments

@ebauger

As I said on the PR, and like Pavlo already noticed, our process works differently. Thank you for your interest in Expensify! You can search for other issues open for proposals.

cubuspl42 on Nov 29, 2023

@ebauger please make sure you’re familiar with the Contribution Guidelines.

This issue is closed, and you shouldn’t create a PR until you’re assigned to the issue.

paultsimura on Nov 28, 2023

Contributor details Your Expensify account email: etienne@eba.expert Upwork Profile Link: https://www.upwork.com/freelancers/~01ee2f0e8b16689ccb

Proposal

This line can fail when a GitHub issue has a ’ in the title and it has the deploy blocker label applied to it:

What is the root cause of that problem?

Wrong string format in YAML for the workflow

What changes do you think we should make in order to solve the problem?

replace single quotes (') with backticks () in GitHub Actions workflow deployBlocker.yml` on line 35.

What alternative solutions did you explore? (Optional)

The issue can be from this project: 8398a7/action-slack

PR : https://github.com/Expensify/App/pull/32136

ebauger on Nov 28, 2023

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

melvin-bot[bot] on Nov 28, 2023