App: [$500] BUG: Workspace room name input not grayed out when pending update fails

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Sign in with any account
  2. Create a workspace from the green plus (if needed)
  3. Create a workspace room from the green plus (if needed)
  4. Go offline
  5. Click the header of the workspace room to open the room details page
  6. Click “Settings”
  7. Rename the room (#examplerename) and hit save
  8. Verify that the input is grayed out (50% opacity)
  9. Sign into the same account on another device or incognito window
  10. Create another workspace room on the same workspace with the same name (#examplerename)
  11. Go back to the other device and go back online
  12. Verify that there is a red dot and an error message saying “A room with this name already exists”.
  13. Verify that there is a red dot on the LHN

Expected Result:

The name input on the workspace room settings page is grayed out (50% opacity)

Actual Result:

The name input on the workspace room settings page is not grayed out (50% opacity)

Workaround:

Ignore it.

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: v1.2.15-3 Reproducible in staging?: Yes Reproducible in production?: Yes Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: image

Expensify/Expensify Issue URL: Issue reported by: @neil-marcellini Slack conversation:

View all open jobs on GitHub

About this issue

  • Original URL
  • State: closed
  • Created 2 years ago
  • Comments: 37 (24 by maintainers)

Most upvoted comments

My bad, this is not an issue. Thanks to @parasharrajat for pointing that out. Inputs should only be grayed out while online if there was a creation error. This code is correct. https://github.com/Expensify/App/blob/376c3327bdc58e0fb15ff31fa7ebba819a680206/src/components/OfflineWithFeedback.js#L88

The name input on the workspace room settings page should be grayed out when there was an error updating it. I’ll edit the issue description to make it more clear.

The inputs on the workspace room settings page are grayed out (50% opacity)

We’re missing the word room in the expected/actual result, but that’s the meaning as it’s also the language used in the reproduction steps.

Once I’m done with my current bug, I’ll come back if this one is still up for grabs.

We should consider taking this one internal, as it’s blocking a test script from being added to TestRail. In the meantime, maybe doubling the price again will help encourage contributor proposals!

This is probably a good external candidate right @neil-marcellini ?

Yep. I looked at the code a bit myself and I’m actually not sure why it isn’t working right now. I don’t think it will require any backend changes. The errors and pendingAction passed to OfflineWithFeedback are set correctly, but for some reason the opacity is not applied. https://github.com/Expensify/App/blob/83676c1036299ffecbf82f4b829a7f8cbd741cd7/src/pages/ReportSettingsPage.js#L165-L169

I simplified the reproduction steps so hopefully they are more clear now.