App: [$500] Expense - System message for paid expense shows payer, while the copied content is workspace
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.20-2 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
Action Performed:
- [Member] Request money in workspace chat
- [Admin] Pay the request
- [Member] Click on the expense preview to go to expense report
- [Member] Right click on the paid system message > Copy to clipboard
- [Member] Paste the content Note that
Expected Result:
- The system message should always start with the action, not the actor, regardless of who is viewing the chat. So the system message should read
paid $10rather thanJohn paid $10orJohn's Workspace paid $10. - When a user copies a system message, we should copy only what is printed, rather than adding the actor (so we should copy
paid $10instead of copyingJohn Doe paid $10)
Actual Result:
- Depending on who is viewing the report, the system message shows either
paid amount elsewhereor[admin] paid amount elsewhere. - When the user copies and pastes the system message, it shows something different from what was printed originally (it shows
[Workspace name] paid amount elsewhere.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/78819774/5e7957cd-b471-49d5-be0c-4a263da2187f
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~015bfbfa9935f7c034
- Upwork Job ID: 1741887749877055488
- Last Price Increase: 2024-01-22
- Automatic offers:
- DylanDylann | Reviewer | 28147572
- dukenv0307 | Contributor | 28147573
About this issue
- Original URL
- State: closed
- Created 6 months ago
- Comments: 57 (36 by maintainers)
We are reverting the PR: https://github.com/Expensify/App/pull/36932
I think a few considerations were missed as part of the planning of this ~feature request~ bug.
Yeah, I think generally what you copy should be what you see, so let’s copy the message being previewed.
P.s why does the receipt thumbnail appear to zoom like that, man? 😂 👀
@DylanDylann reassigning, please take over as C+. If you don’t have bandwidth, unassign yourself. Thanks