App: [$4000] App crashes if you send an image immediately after renaming the workspace with <
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
-
Go to staging dot on web chrome
-
Click on Profile and Create a new Workspace
-
Click on the Workspace name and rename it to
<my workspace(there should not be gap between < and the workspace name) -
Notice the workspace name is saved on the #admin room
-
Go to workspace settings and add any word or letter after the previous name set and click on save to rename the workspace again.
-
Now on #admins room, send an image and click on it to preview (ex:
)
Notice that the app crashes.
- App doesn’t crash if workspace name is set to a normal name. Happens if you rename the workspace with ‘<’ 2 times.
Expected Result:
Preview should work when a workspace is named with <
Actual Result:
App crashes if you send an image immediately after renaming the workspace with <
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: 1.3.29-3 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/43996225/92fc94a1-fbe1-4b4f-bb42-b9036cb79949
https://github.com/Expensify/App/assets/43996225/53b7632e-4cfe-40ca-bb19-b97ecc9c5137
Expensify/Expensify Issue URL: Issue reported by: @priya-zha Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686807235965749
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~012613bc6123fc7e67
- Upwork Job ID: 1671273021780578304
- Last Price Increase: 2023-08-15
About this issue
- Original URL
- State: closed
- Created a year ago
- Comments: 146 (89 by maintainers)
@CortneyOfstad as we’re still looking for proposals, can we add back External?
Crash now changed to Not found page. The root cause still remains
https://github.com/Expensify/App/assets/96077027/9fcd729d-2154-4313-93ff-90e6b8f427bc
As it’s not crash, let’s close for now. I will bump here to re-open when wave projects are finished and ready to focus these bugs again.
Oh sorry, I’m still focused on wave7, I think it still requires a backend fix. I can take a look quickly tomorrow
This is “crash” so I think it should be fixed. If engineers have no time to fix in backend, we can just do frontend fix to avoid crash.
No update until wave 7 is done — changing the frequency 👍
Oh interesting, thanks @akamefi202 for the analysis, I agree that we should return the escaped message from backend when the workspace name changes. I will change this issue to internal to fix it.
@Christinadobrzyn can take this back, now that I have returned from OoO — thanks for keeping an eye on this!
@marcochavezf bump on the comment above from @aimane-chnaif on the proposal ^^^ TIA!
Now the behavior changed for this issue. Instead of crash, nothing happens when go to preview. Still root cause remaining of course.
https://github.com/Expensify/App/assets/96077027/66dc1b28-4901-4f15-8b43-abe53322eace
I am evaluating last proposal but yes, still wanna see better proposal
Back from ooo - I can take this back @CortneyOfstad thanks for handling it!
Let’s raise the bounty to get more proposals.
I was still looking for better solution
I don’t think we’ve decided on a proposal - I added @aimane-chnaif as the C+ taking over for @rushatgabhane based on https://github.com/Expensify/App/issues/21133#issuecomment-1621548393
@aimane-chnaif will be reviewing the proposals.
Welcome @aimane-chnaif! You were assigned as C+ based on https://github.com/Expensify/App/issues/21133#issuecomment-1621548393
I think there are a few proposals so let us know if you see any that look like a good fit or if you’d like to see more proposals!
Hi @marcochavezf @Christinadobrzyn, I don’t completely understand this issue and the proposals here. Could you please re-add the
Externallabel to assign a different C+? Thanks