App: [$250] Vertical keyboard padding is shown beneath input when opening chat

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  • Navigate to Settings > Profile
  • Tap the ‘First name’ input field
  • Without manually closing the keyboard, close the modal with the ‘x’ button
  • Navigate to any chat

Expected Result:

  • There should not be padding beneath the input

Actual Result:

  • There is keyboard-sized vertical padding beneath the input

Platform:

Where is this issue occurring?

  • iOS: iPhone 7, iOS 13.3
Screenshot 2022-10-25 at 11 35 16

Version Number: v1.2.18-8 Reproducible in staging?: Yes Reproducible in production?: Yes

View all open jobs on GitHub

About this issue

  • Original URL
  • State: closed
  • Created 2 years ago
  • Comments: 24 (15 by maintainers)

Most upvoted comments

I think the list of iOS versions that we support is maintained by Applause. I don’t think we have it written down anywhere, but if you ask Applause, I’m sure they could tell you the versions they test on (which would be the same as the versions we support).

On Thu, Nov 3, 2022 at 4:52 AM Jules @.***> wrote:

do we have a list of iOS versions that we officially support? I wouldn’t expect this one to be on it, that’s 4 years old, right?

I don’t believe we have. Our Android support goes far back also and while we should restrict this eventually it’s a separate discussion than needs context on the version market share. Having said that, I don’t think we should be blocking devices that are still receiving OS security updates from Apple/Google.

I recently faced this issue on iOS 15. This is a very serious issue. Let’s prioritize this.

Anyway, seems like this is occurring on newer devices too 👍

— Reply to this email directly, view it on GitHub https://github.com/Expensify/App/issues/12114#issuecomment-1301925366, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJMAB4FZIYEYOWG26762HTWGOKQFANCNFSM6AAAAAARN24GLQ . You are receiving this because you were assigned.Message ID: @.***>

This is no longer on hold and can have proposals created for it with the new code.

Oh we’re actually good, I confused the GH issues 😅 I had another one with Jules for which I posted the job in Upwork this morning, but I had not posted one for this issue. I’ll switch this one to weekly then until it’s removed from hold.

OK, I just tried it out with my branch and it is still broken there. Let’s keep this issue on HOLD until my PR is merged though (so we can get proposals based on the right code). If we can’t pause the Upwork job, then maybe it is best to delete it for now.

I’ve added a HOLD to this and added it to the master tracking GH for now. I’ll have to take a look at this on my branch and see if it’s fixed yet or not.