App: [$250] Update electron-builder package to latest version
Action Performed:
Check which version of electron builder is here. (You can csee what version we are using by running the command npm list ejs)
Expected Result:
The version used by Expensify should match the latest version listed here
Actual Result:
Expensify currently uses electron-builder version 22.13.1
Workaround:
na
Platform:
Where is this issue occurring?
- Web
- iOS
- Android
- Desktop App
- Mobile Web
About this issue
- Original URL
- State: closed
- Created 2 years ago
- Comments: 20 (14 by maintainers)
Ok. I see. This is straightforward. I like @dennismunene’s proposal. You will have to provide the following on the PR.
Do then the app signing. It should not break.
cc: @Beamanator
🎀 👀 🎀 C+ reviewed
@Christinadobrzyn I believe this is ready to be paid out and closed! It was mentioned here that the changes worked, in production 👍
Technically PR was merged, just waiting for it to be deployed 😄
working on the PR
Hired @dennismunene for the fix in Upwork ($250) Hired @parasharrajat as the C+ in Upwork ($250)
PR in review - https://github.com/Expensify/App/pull/10159
I think it can be!
Just running this past eng per our triage workflow! If it’s good for a contributor please add the External label!
Hey @Christinadobrzyn! This issue was discussed here as likely a great external candidate